third_party/WebKit/Source/platform/v8_inspector/V8StackTraceImpl.h - Issue 2035653006: [DevTools] Move Console to v8 inspector.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/V8StackTraceImpl.h

Issue 2035653006: [DevTools] Move Console to v8 inspector. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: improved api a bit Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp ('k') | third_party/WebKit/Source/platform/v8_inspector/V8StackTraceImpl.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/v8_inspector/V8StackTraceImpl.h

diff --git a/third_party/WebKit/Source/platform/v8_inspector/V8StackTraceImpl.h b/third_party/WebKit/Source/platform/v8_inspector/V8StackTraceImpl.h

index 77f07546209278472b51c1f0dff13f2e37ba21bd..63b59e8d9009b3777dfe7239a9b02bfa197bf1d8 100644

--- a/third_party/WebKit/Source/platform/v8_inspector/V8StackTraceImpl.h

+++ b/third_party/WebKit/Source/platform/v8_inspector/V8StackTraceImpl.h

@@ -21,6 +21,8 @@ class V8DebuggerImpl;

class V8StackTraceImpl final : public V8StackTrace {

PROTOCOL_DISALLOW_COPY(V8StackTraceImpl);

public:

+ static const size_t maxCallStackSizeToCapture = 200;

class Frame {

public:

Frame();

@@ -46,6 +48,7 @@ public:

int m_columnNumber;

};

+ static void setCaptureStackTraceForUncaughtExceptions(v8::Isolate*, bool capture);

static std::unique_ptr<V8StackTraceImpl> create(V8DebuggerImpl*, int contextGroupId, v8::Local<v8::StackTrace>, size_t maxStackSize, const String16& description = String16());

static std::unique_ptr<V8StackTraceImpl> capture(V8DebuggerImpl*, int contextGroupId, size_t maxStackSize, const String16& description = String16());