Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Unified Diff: third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp

Issue 2035653006: [DevTools] Move Console to v8 inspector. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: improved api a bit Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp
diff --git a/third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp b/third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp
index 7b5a6e3e5d421427f64a413d15d0568764db9d90..c0efd2e63c815c774f1b88e9fb363c8821291880 100644
--- a/third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp
+++ b/third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp
@@ -55,7 +55,6 @@
#include "core/inspector/InspectorWorkerAgent.h"
#include "core/inspector/LayoutEditor.h"
#include "core/inspector/MainThreadDebugger.h"
-#include "core/inspector/PageConsoleAgent.h"
#include "core/layout/api/LayoutViewItem.h"
#include "core/page/FocusController.h"
#include "core/page/Page.h"
@@ -392,8 +391,6 @@ void WebDevToolsAgentImpl::initializeSession(int sessionId, const String& hostId
m_session->append(InspectorIndexedDBAgent::create(m_inspectedFrames.get()));
- m_session->append(new PageConsoleAgent(m_session->v8Session(), m_domAgent, m_inspectedFrames.get()));
-
InspectorWorkerAgent* workerAgent = new InspectorWorkerAgent(m_inspectedFrames.get());
m_session->append(workerAgent);
@@ -599,6 +596,12 @@ void WebDevToolsAgentImpl::profilingStopped()
m_overlay->resume();
}
+void WebDevToolsAgentImpl::consoleCleared()
+{
+ if (m_domAgent)
+ m_domAgent->releaseDanglingNodes();
+}
+
void WebDevToolsAgentImpl::pageLayoutInvalidated(bool resized)
{
if (m_overlay)
« no previous file with comments | « third_party/WebKit/Source/web/WebDevToolsAgentImpl.h ('k') | third_party/WebKit/Source/web/WebPepperSocketImpl.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698