third_party/WebKit/Source/core/inspector/ThreadDebugger.h - Issue 2035653006: [DevTools] Move Console to v8 inspector.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/inspector/ThreadDebugger.h

Issue 2035653006: [DevTools] Move Console to v8 inspector. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: improved api a bit Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/inspector/ScriptArguments.cpp ('k') | third_party/WebKit/Source/core/inspector/ThreadDebugger.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/inspector/ThreadDebugger.h

diff --git a/third_party/WebKit/Source/core/inspector/ThreadDebugger.h b/third_party/WebKit/Source/core/inspector/ThreadDebugger.h

index 512528f15911c54504b19455d12d894c25b4c6a7..e613af24fcabb0b68808f5c2913ef6dd26a9563f 100644

--- a/third_party/WebKit/Source/core/inspector/ThreadDebugger.h

+++ b/third_party/WebKit/Source/core/inspector/ThreadDebugger.h

@@ -49,7 +49,6 @@ public:

void enableAsyncInstrumentation() override;

void disableAsyncInstrumentation() override;

void installAdditionalCommandLineAPI(v8::Local<v8::Context>, v8::Local<v8::Object>) override;

- void reportMessageToConsole(v8::Local<v8::Context>, MessageType, MessageLevel, const String16& message, const v8::FunctionCallbackInfo<v8::Value>* arguments, unsigned skipArgumentCount) final;

void consoleTime(const String16& title) override;

void consoleTimeEnd(const String16& title) override;

void consoleTimeStamp(const String16& title) override;

@@ -58,9 +57,9 @@ public:

V8Debugger* debugger() const { return m_debugger.get(); }

virtual bool isWorker() { return true; }

protected:

void createFunctionProperty(v8::Local<v8::Context>, v8::Local<v8::Object>, const char* name, v8::FunctionCallback, const char* description);

- virtual void reportMessageToConsole(v8::Local<v8::Context>, ConsoleMessage*) = 0;

void onTimer(Timer<ThreadDebugger>*);

v8::Isolate* m_isolate;