Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 2033403005: Eradicate keyIndentifier from devtools/* (Closed)

Created:
4 years, 6 months ago by dtapuska
Modified:
4 years, 6 months ago
Reviewers:
caseq, dgozman
CC:
chromium-reviews, extensions-reviews_chromium.org, caseq+blink_chromium.org, blink-reviews-style_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, chromium-apps-reviews_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org, dgozman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Eradicate keyIndentifier from devtools/* keyIdentifier is going to be deprecated; we need to stop using it. No functional changes intended. A few instances remain with respect to extensions and keyIdentifier. Those need to be handled so that we don't break existing extensions. BUG=607349 Committed: https://crrev.com/38625c390884254b2edb178e7e0ca1c301817002 Cr-Commit-Position: refs/heads/master@{#401423}

Patch Set 1 #

Patch Set 2 : Rebase and fix extensions_panel #

Patch Set 3 : Add keyIdentifier getter/setter if keyIdentifier is not defined #

Total comments: 16

Patch Set 4 : Use a map #

Patch Set 5 : Attempt to fix mac debug build #

Patch Set 6 : Fix mac build attempt 2 #

Total comments: 4

Patch Set 7 : Remove keyIdentifier from c++ window hook #

Total comments: 2

Patch Set 8 : Call KeyCodeToKeyIdentifier for unhandle key events #

Unified diffs Side-by-side diffs Delta from patch set Stats (+190 lines, -98 lines) Patch
M chrome/browser/devtools/BUILD.gn View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/devtools/devtools_window.cc View 1 2 3 4 5 6 2 chunks +5 lines, -1 line 0 comments Download
M chrome/chrome_debugger.gypi View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/console-test.js View 1 2 3 1 chunk +6 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-auto-completion.html View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/extensions/extensions-panel.html View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorOverlayPage.html View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/Tests.js View 1 1 chunk +2 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/components/ObjectPropertiesSection.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/components_lazy/FilmStripView.js View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/devices/DevicesView.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/devtools.js View 1 2 3 4 5 6 7 3 chunks +84 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/elements/ElementsPanel.js View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeOutline.js View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/elements/Spectrum.js View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/elements/StylesPopoverHelper.js View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js View 4 chunks +6 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/extensions/ExtensionAPI.js View 2 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/extensions/ExtensionServer.js View 1 2 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/network/BlockedURLsPane.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/platform/DOMExtension.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/profiler/ProfilesPanel.js View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/screencast/ScreencastView.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/CallStackSidebarPane.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/FilterBar.js View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/ForwardedInputEventHandler.js View 1 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/InplaceEditor.js View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/InspectorView.js View 3 chunks +3 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/ShortcutRegistry.js View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/SoftContextMenu.js View 2 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/SuggestBox.js View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/TextPrompt.js View 2 chunks +13 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/UIUtils.js View 3 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/treeoutline.js View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui_lazy/DataGrid.js View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 26 (7 generated)
dtapuska
PTAL
4 years, 6 months ago (2016-06-09 21:41:17 UTC) #3
pfeldman
could you hint us on the deprecation schedule?
4 years, 6 months ago (2016-06-10 01:52:10 UTC) #4
dtapuska
On 2016/06/10 01:52:10, pfeldman wrote: > could you hint us on the deprecation schedule? It ...
4 years, 6 months ago (2016-06-10 03:17:26 UTC) #5
dgozman
I think we have to add a polyfill to installBackwardsCompatibility in Source/devtools/front_end/devtools.js, so that all ...
4 years, 6 months ago (2016-06-10 07:39:40 UTC) #6
caseq
On 2016/06/10 07:39:40, dgozman_slow wrote: > I think we have to add a polyfill to ...
4 years, 6 months ago (2016-06-10 16:46:10 UTC) #7
dtapuska
On 2016/06/10 16:46:10, caseq wrote: > On 2016/06/10 07:39:40, dgozman_slow wrote: > > I think ...
4 years, 6 months ago (2016-06-10 17:42:37 UTC) #8
caseq
https://codereview.chromium.org/2033403005/diff/40001/third_party/WebKit/LayoutTests/http/tests/inspector/console-test.js File third_party/WebKit/LayoutTests/http/tests/inspector/console-test.js (right): https://codereview.chromium.org/2033403005/diff/40001/third_party/WebKit/LayoutTests/http/tests/inspector/console-test.js#newcode31 third_party/WebKit/LayoutTests/http/tests/inspector/console-test.js:31: }); reformat to use indent of 4: var event ...
4 years, 6 months ago (2016-06-10 18:59:11 UTC) #9
dtapuska
PTAL; I've converted to use the map. https://codereview.chromium.org/2033403005/diff/40001/third_party/WebKit/LayoutTests/http/tests/inspector/console-test.js File third_party/WebKit/LayoutTests/http/tests/inspector/console-test.js (right): https://codereview.chromium.org/2033403005/diff/40001/third_party/WebKit/LayoutTests/http/tests/inspector/console-test.js#newcode31 third_party/WebKit/LayoutTests/http/tests/inspector/console-test.js:31: }); On ...
4 years, 6 months ago (2016-06-10 20:25:44 UTC) #10
caseq
On 2016/06/10 20:25:44, dtapuska wrote: > https://codereview.chromium.org/2033403005/diff/40001/third_party/WebKit/Source/devtools/front_end/ui/TextPrompt.js#newcode988 > third_party/WebKit/Source/devtools/front_end/ui/TextPrompt.js:988: case "n": > On 2016/06/10 18:59:11, ...
4 years, 6 months ago (2016-06-10 20:42:41 UTC) #11
dtapuska
On 2016/06/10 20:42:41, caseq wrote: > On 2016/06/10 20:25:44, dtapuska wrote: > > > > ...
4 years, 6 months ago (2016-06-10 20:45:30 UTC) #12
caseq
On 2016/06/10 20:45:30, dtapuska wrote: lgtm. > No; event.code is the keyboard as a US ...
4 years, 6 months ago (2016-06-10 20:57:31 UTC) #13
dtapuska
dgozman@chromium.org: Please review changes in chrome/browser/devtools/*
4 years, 6 months ago (2016-06-15 21:40:42 UTC) #15
dgozman
https://codereview.chromium.org/2033403005/diff/100001/chrome/browser/devtools/devtools_window.cc File chrome/browser/devtools/devtools_window.cc (right): https://codereview.chromium.org/2033403005/diff/100001/chrome/browser/devtools/devtools_window.cc#newcode276 chrome/browser/devtools/devtools_window.cc:276: event_data.SetString("keyIdentifier", event.keyIdentifier); Do we have to pass this? I ...
4 years, 6 months ago (2016-06-16 06:55:01 UTC) #16
dtapuska
https://codereview.chromium.org/2033403005/diff/100001/chrome/browser/devtools/devtools_window.cc File chrome/browser/devtools/devtools_window.cc (right): https://codereview.chromium.org/2033403005/diff/100001/chrome/browser/devtools/devtools_window.cc#newcode276 chrome/browser/devtools/devtools_window.cc:276: event_data.SetString("keyIdentifier", event.keyIdentifier); On 2016/06/16 06:55:00, dgozman_slow wrote: > Do ...
4 years, 6 months ago (2016-06-16 07:36:11 UTC) #17
dgozman
lgtm with comment https://codereview.chromium.org/2033403005/diff/120001/third_party/WebKit/Source/devtools/front_end/devtools.js File third_party/WebKit/Source/devtools/front_end/devtools.js (right): https://codereview.chromium.org/2033403005/diff/120001/third_party/WebKit/Source/devtools/front_end/devtools.js#newcode236 third_party/WebKit/Source/devtools/front_end/devtools.js:236: this._dispatchOnInspectorFrontendAPI("keyEventUnhandled", [event]); Note that we still ...
4 years, 6 months ago (2016-06-16 13:50:33 UTC) #18
dtapuska
https://codereview.chromium.org/2033403005/diff/120001/third_party/WebKit/Source/devtools/front_end/devtools.js File third_party/WebKit/Source/devtools/front_end/devtools.js (right): https://codereview.chromium.org/2033403005/diff/120001/third_party/WebKit/Source/devtools/front_end/devtools.js#newcode236 third_party/WebKit/Source/devtools/front_end/devtools.js:236: this._dispatchOnInspectorFrontendAPI("keyEventUnhandled", [event]); On 2016/06/16 13:50:33, dgozman wrote: > Note ...
4 years, 6 months ago (2016-06-22 18:50:45 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2033403005/140001
4 years, 6 months ago (2016-06-22 20:39:24 UTC) #22
commit-bot: I haz the power
Committed patchset #8 (id:140001)
4 years, 6 months ago (2016-06-22 21:58:58 UTC) #24
commit-bot: I haz the power
4 years, 6 months ago (2016-06-22 22:01:27 UTC) #26
Message was sent while issue was closed.
Patchset 8 (id:??) landed as
https://crrev.com/38625c390884254b2edb178e7e0ca1c301817002
Cr-Commit-Position: refs/heads/master@{#401423}

Powered by Google App Engine
This is Rietveld 408576698