third_party/WebKit/Source/devtools/front_end/ui/FilterBar.js - Issue 2033403005: Eradicate keyIndentifier from devtools/*

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/ui/FilterBar.js

Issue 2033403005: Eradicate keyIndentifier from devtools/* (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Call KeyCodeToKeyIdentifier for unhandle key events Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/devtools/front_end/ui/FilterBar.js

diff --git a/third_party/WebKit/Source/devtools/front_end/ui/FilterBar.js b/third_party/WebKit/Source/devtools/front_end/ui/FilterBar.js

index d4f692f2b262a640579e2213d4e71060a939d31c..5d71cc9ccf86ff1281cea1ec9a70908a2d94eba6 100644

--- a/third_party/WebKit/Source/devtools/front_end/ui/FilterBar.js

+++ b/third_party/WebKit/Source/devtools/front_end/ui/FilterBar.js

@@ -417,13 +417,13 @@ WebInspector.TextFilterUI.prototype = {

_onInputKeyDown: function(event)

{

var handled = false;

- if (event.keyIdentifier === "U+0008") { // Backspace

+ if (event.key === "Backspace") {

this._suppressSuggestion = true;

} else if (this._suggestBox.visible()) {

- if (event.keyIdentifier === "U+001B") { // Esc

+ if (event.key === "Escape") {

this._cancelSuggestion();

handled = true;

- } else if (event.keyIdentifier === "U+0009") { // Tab

+ } else if (event.key === "Tab") {

this._suggestBox.acceptSuggestion();

this._valueChanged(true);

handled = true;