Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(637)

Unified Diff: third_party/WebKit/Source/devtools/front_end/ui_lazy/DataGrid.js

Issue 2033403005: Eradicate keyIndentifier from devtools/* (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Call KeyCodeToKeyIdentifier for unhandle key events Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/ui/treeoutline.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/devtools/front_end/ui_lazy/DataGrid.js
diff --git a/third_party/WebKit/Source/devtools/front_end/ui_lazy/DataGrid.js b/third_party/WebKit/Source/devtools/front_end/ui_lazy/DataGrid.js
index ebbfc16a1d26480dd7348c765ab4ee2b03be32b5..21cf69600ff39a0ca8a5f40ec65b33f25a146006 100644
--- a/third_party/WebKit/Source/devtools/front_end/ui_lazy/DataGrid.js
+++ b/third_party/WebKit/Source/devtools/front_end/ui_lazy/DataGrid.js
@@ -789,17 +789,17 @@ WebInspector.DataGrid.prototype = {
var handled = false;
var nextSelectedNode;
- if (event.keyIdentifier === "Up" && !event.altKey) {
+ if (event.key === "ArrowUp" && !event.altKey) {
nextSelectedNode = this.selectedNode.traversePreviousNode(true);
while (nextSelectedNode && !nextSelectedNode.selectable)
nextSelectedNode = nextSelectedNode.traversePreviousNode(true);
handled = nextSelectedNode ? true : false;
- } else if (event.keyIdentifier === "Down" && !event.altKey) {
+ } else if (event.key === "ArrowDown" && !event.altKey) {
nextSelectedNode = this.selectedNode.traverseNextNode(true);
while (nextSelectedNode && !nextSelectedNode.selectable)
nextSelectedNode = nextSelectedNode.traverseNextNode(true);
handled = nextSelectedNode ? true : false;
- } else if (event.keyIdentifier === "Left") {
+ } else if (event.key === "ArrowLeft") {
if (this.selectedNode.expanded) {
if (event.altKey)
this.selectedNode.collapseRecursively();
@@ -814,7 +814,7 @@ WebInspector.DataGrid.prototype = {
} else if (this.selectedNode.parent)
this.selectedNode.parent.collapse();
}
- } else if (event.keyIdentifier === "Right") {
+ } else if (event.key === "ArrowRight") {
if (!this.selectedNode.revealed) {
this.selectedNode.reveal();
handled = true;
« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/ui/treeoutline.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698