third_party/WebKit/Source/devtools/front_end/components/ObjectPropertiesSection.js - Issue 2033403005: Eradicate keyIndentifier from devtools/*

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/components/ObjectPropertiesSection.js

Issue 2033403005: Eradicate keyIndentifier from devtools/* (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Call KeyCodeToKeyIdentifier for unhandle key events Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/Tests.js ('k') | third_party/WebKit/Source/devtools/front_end/components_lazy/FilmStripView.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/components/ObjectPropertiesSection.js

diff --git a/third_party/WebKit/Source/devtools/front_end/components/ObjectPropertiesSection.js b/third_party/WebKit/Source/devtools/front_end/components/ObjectPropertiesSection.js

index eb34f0e3918bb50ff2503e662191e8f726c7df23..1caef0413a06aa74054ca3efc4b379c5298f2370 100644

--- a/third_party/WebKit/Source/devtools/front_end/components/ObjectPropertiesSection.js

+++ b/third_party/WebKit/Source/devtools/front_end/components/ObjectPropertiesSection.js

@@ -425,7 +425,7 @@ WebInspector.ObjectPropertyTreeElement.prototype = {

this._editingCommitted(originalContent);

return;

}

- if (event.keyIdentifier === "U+001B") { // Esc

+ if (event.key === "Escape") {

event.consume();

this._editingCancelled();

return;