third_party/WebKit/Source/devtools/front_end/elements/Spectrum.js - Issue 2033403005: Eradicate keyIndentifier from devtools/*

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/elements/Spectrum.js

Issue 2033403005: Eradicate keyIndentifier from devtools/* (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Call KeyCodeToKeyIdentifier for unhandle key events Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/devtools/front_end/elements/Spectrum.js

diff --git a/third_party/WebKit/Source/devtools/front_end/elements/Spectrum.js b/third_party/WebKit/Source/devtools/front_end/elements/Spectrum.js

index fd43e8c6d6ec5e445750c09e75cb877778db6f01..a91e6bebfdd35680c0e663ab67ed627c9ec33c60 100644

--- a/third_party/WebKit/Source/devtools/front_end/elements/Spectrum.js

+++ b/third_party/WebKit/Source/devtools/front_end/elements/Spectrum.js

@@ -837,8 +837,8 @@ WebInspector.Spectrum.prototype = {

}

var inputElement = /** @type {!Element} */(event.currentTarget);

- var arrowKeyOrMouseWheelEvent = (event.keyIdentifier === "Up" || event.keyIdentifier === "Down" || event.type === "mousewheel");

- var pageKeyPressed = (event.keyIdentifier === "PageUp" || event.keyIdentifier === "PageDown");

+ var arrowKeyOrMouseWheelEvent = (event.key === "ArrowUp" || event.key === "ArrowDown" || event.type === "mousewheel");

+ var pageKeyPressed = (event.key === "PageUp" || event.key === "PageDown");

if (arrowKeyOrMouseWheelEvent || pageKeyPressed) {

var newValue = WebInspector.createReplacementString(inputElement.value, event);

if (newValue) {