third_party/WebKit/Source/devtools/front_end/ui/ForwardedInputEventHandler.js - Issue 2033403005: Eradicate keyIndentifier from devtools/*

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/ui/ForwardedInputEventHandler.js

Issue 2033403005: Eradicate keyIndentifier from devtools/* (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Call KeyCodeToKeyIdentifier for unhandle key events Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/ui/FilterBar.js ('k') | third_party/WebKit/Source/devtools/front_end/ui/InplaceEditor.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/ui/ForwardedInputEventHandler.js

diff --git a/third_party/WebKit/Source/devtools/front_end/ui/ForwardedInputEventHandler.js b/third_party/WebKit/Source/devtools/front_end/ui/ForwardedInputEventHandler.js

index 7ee28d552487fb1b91fc6c5465cd632918107967..a894b82010dbd313cd7585135cf4d3d385f0f12e 100644

--- a/third_party/WebKit/Source/devtools/front_end/ui/ForwardedInputEventHandler.js

+++ b/third_party/WebKit/Source/devtools/front_end/ui/ForwardedInputEventHandler.js

@@ -18,7 +18,7 @@ WebInspector.ForwardedInputEventHandler.prototype = {

{

var data = event.data;

var type = /** @type {string} */ (data.type);

- var keyIdentifier = /** @type {string} */ (data.keyIdentifier);

+ var key = /** @type {string} */ (data.key);

var keyCode = /** @type {number} */ (data.keyCode);

var modifiers =/** @type {number} */ (data.modifiers);

@@ -26,7 +26,7 @@ WebInspector.ForwardedInputEventHandler.prototype = {

return;

WebInspector.context.setFlavor(WebInspector.ShortcutRegistry.ForwardedShortcut, WebInspector.ShortcutRegistry.ForwardedShortcut.instance);

- WebInspector.shortcutRegistry.handleKey(WebInspector.KeyboardShortcut.makeKey(keyCode, modifiers), keyIdentifier);

+ WebInspector.shortcutRegistry.handleKey(WebInspector.KeyboardShortcut.makeKey(keyCode, modifiers), key);

WebInspector.context.setFlavor(WebInspector.ShortcutRegistry.ForwardedShortcut, null);

}