third_party/WebKit/Source/devtools/front_end/components_lazy/FilmStripView.js - Issue 2033403005: Eradicate keyIndentifier from devtools/*

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/components_lazy/FilmStripView.js

Issue 2033403005: Eradicate keyIndentifier from devtools/* (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Call KeyCodeToKeyIdentifier for unhandle key events Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/components/ObjectPropertiesSection.js ('k') | third_party/WebKit/Source/devtools/front_end/devices/DevicesView.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/components_lazy/FilmStripView.js

diff --git a/third_party/WebKit/Source/devtools/front_end/components_lazy/FilmStripView.js b/third_party/WebKit/Source/devtools/front_end/components_lazy/FilmStripView.js

index 64bb74f1cec042c378acb0966bcc3bf6cf4e46f7..d244f52c318957e1584e90a0acd06439733cac89 100644

--- a/third_party/WebKit/Source/devtools/front_end/components_lazy/FilmStripView.js

+++ b/third_party/WebKit/Source/devtools/front_end/components_lazy/FilmStripView.js

@@ -264,15 +264,15 @@ WebInspector.FilmStripView.Dialog.prototype = {

_keyDown: function(event)

{

- switch (event.keyIdentifier) {

- case "Left":

+ switch (event.key) {

+ case "ArrowLeft":

if (WebInspector.isMac() && event.metaKey)

this._onFirstFrame();

else

this._onPrevFrame();

break;

- case "Right":

+ case "ArrowRight":

if (WebInspector.isMac() && event.metaKey)

this._onLastFrame();

else