Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Unified Diff: third_party/WebKit/Source/devtools/front_end/ui/treeoutline.js

Issue 2033403005: Eradicate keyIndentifier from devtools/* (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Call KeyCodeToKeyIdentifier for unhandle key events Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/ui/treeoutline.js
diff --git a/third_party/WebKit/Source/devtools/front_end/ui/treeoutline.js b/third_party/WebKit/Source/devtools/front_end/ui/treeoutline.js
index cb748997ddac0b575f322dbd5e7ab5e5dad9da0f..007e68e654979e77f00907ef094dffaeb84aa7a1 100644
--- a/third_party/WebKit/Source/devtools/front_end/ui/treeoutline.js
+++ b/third_party/WebKit/Source/devtools/front_end/ui/treeoutline.js
@@ -231,11 +231,11 @@ TreeOutline.prototype = {
var handled = false;
var nextSelectedElement;
- if (event.keyIdentifier === "Up" && !event.altKey) {
+ if (event.key === "ArrowUp" && !event.altKey) {
handled = this.selectPrevious();
- } else if (event.keyIdentifier === "Down" && !event.altKey) {
+ } else if (event.key === "ArrowDown" && !event.altKey) {
handled = this.selectNext();
- } else if (event.keyIdentifier === "Left") {
+ } else if (event.key === "ArrowLeft") {
if (this.selectedTreeElement.expanded) {
if (event.altKey)
this.selectedTreeElement.collapseRecursively();
@@ -252,7 +252,7 @@ TreeOutline.prototype = {
} else if (this.selectedTreeElement.parent)
this.selectedTreeElement.parent.collapse();
}
- } else if (event.keyIdentifier === "Right") {
+ } else if (event.key === "ArrowRight") {
if (!this.selectedTreeElement.revealed()) {
this.selectedTreeElement.reveal();
handled = true;

Powered by Google App Engine
This is Rietveld 408576698