third_party/WebKit/Source/devtools/front_end/Tests.js - Issue 2033403005: Eradicate keyIndentifier from devtools/*

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/Tests.js

Issue 2033403005: Eradicate keyIndentifier from devtools/* (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Call KeyCodeToKeyIdentifier for unhandle key events Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/devtools/front_end/Tests.js

diff --git a/third_party/WebKit/Source/devtools/front_end/Tests.js b/third_party/WebKit/Source/devtools/front_end/Tests.js

index 0de240f6c317048ee1ff38d5dfa11c6eea42f39a..a8bfc3eadf8afea927e221972c71a440ec117243 100644

--- a/third_party/WebKit/Source/devtools/front_end/Tests.js

+++ b/third_party/WebKit/Source/devtools/front_end/Tests.js

@@ -1103,11 +1103,9 @@ TestSuite.prototype._waitForTargets = function(n, callback)

/**

* Key event with given key identifier.

-TestSuite.createKeyEvent = function(keyIdentifier)

+TestSuite.createKeyEvent = function(key)

{

- var evt = document.createEvent("KeyboardEvent");

- evt.initKeyboardEvent("keydown", true /* can bubble */, true /* can cancel */, null /* view */, keyIdentifier, "");

- return evt;

+ return new KeyboardEvent("keydown", {bubbles: true, cancelable:true, key: key});

};

window.uiTests = new TestSuite(window.domAutomationController);