third_party/WebKit/Source/devtools/front_end/sources/CallStackSidebarPane.js - Issue 2033403005: Eradicate keyIndentifier from devtools/*

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/sources/CallStackSidebarPane.js

Issue 2033403005: Eradicate keyIndentifier from devtools/* (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Call KeyCodeToKeyIdentifier for unhandle key events Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/screencast/ScreencastView.js ('k') | third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/sources/CallStackSidebarPane.js

diff --git a/third_party/WebKit/Source/devtools/front_end/sources/CallStackSidebarPane.js b/third_party/WebKit/Source/devtools/front_end/sources/CallStackSidebarPane.js

index 09967447427a68af5723c9cc030d61dbc35fe1f7..a874d5a1f3dd0688fb35aaa46a33f9a11b46268a 100644

--- a/third_party/WebKit/Source/devtools/front_end/sources/CallStackSidebarPane.js

+++ b/third_party/WebKit/Source/devtools/front_end/sources/CallStackSidebarPane.js

@@ -425,7 +425,7 @@ WebInspector.CallStackSidebarPane.prototype = {

{

if (event.altKey || event.shiftKey || event.metaKey || event.ctrlKey)

return;

- if (event.keyIdentifier === "Up" && this._selectPreviousCallFrameOnStack() || event.keyIdentifier === "Down" && this._selectNextCallFrameOnStack())

+ if (event.key === "ArrowUp" && this._selectPreviousCallFrameOnStack() || event.key === "ArrowDown" && this._selectNextCallFrameOnStack())

event.consume(true);