third_party/WebKit/Source/devtools/front_end/extensions/ExtensionAPI.js - Issue 2033403005: Eradicate keyIndentifier from devtools/*

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/extensions/ExtensionAPI.js

Issue 2033403005: Eradicate keyIndentifier from devtools/* (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Call KeyCodeToKeyIdentifier for unhandle key events Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js ('k') | third_party/WebKit/Source/devtools/front_end/extensions/ExtensionServer.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/extensions/ExtensionAPI.js

diff --git a/third_party/WebKit/Source/devtools/front_end/extensions/ExtensionAPI.js b/third_party/WebKit/Source/devtools/front_end/extensions/ExtensionAPI.js

index 7a9b305fbc76abcc0829e3ba5893acbb4068899f..3f8150ea4327e8378227213a5ba576985c74c7a9 100644

--- a/third_party/WebKit/Source/devtools/front_end/extensions/ExtensionAPI.js

+++ b/third_party/WebKit/Source/devtools/front_end/extensions/ExtensionAPI.js

@@ -813,9 +813,8 @@ var forwardTimer = null;

function forwardKeyboardEvent(event)

{

- const Esc = "U+001B";

// We only care about global hotkeys, not about random text

- if (!event.ctrlKey && !event.altKey && !event.metaKey && !/^F\d+$/.test(event.keyIdentifier) && event.keyIdentifier !== Esc)

+ if (!event.ctrlKey && !event.altKey && !event.metaKey && !/^F\d+$/.test(event.key) && event.key !== "Escape")

return;

var requestPayload = {

eventType: event.type,

@@ -823,6 +822,8 @@ function forwardKeyboardEvent(event)

altKey: event.altKey,

metaKey: event.metaKey,

keyIdentifier: event.keyIdentifier,

+ key: event.key,

+ code: event.code,

location: event.location,

keyCode: event.keyCode

};