third_party/WebKit/Source/devtools/front_end/ui/SuggestBox.js - Issue 2033403005: Eradicate keyIndentifier from devtools/*

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/ui/SuggestBox.js

Issue 2033403005: Eradicate keyIndentifier from devtools/* (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Call KeyCodeToKeyIdentifier for unhandle key events Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/devtools/front_end/ui/SuggestBox.js

diff --git a/third_party/WebKit/Source/devtools/front_end/ui/SuggestBox.js b/third_party/WebKit/Source/devtools/front_end/ui/SuggestBox.js

index 188772dbbc5974576d079f225e93812753abb8e0..21e4bf4d48bb0102b776f6534a11542a885d1855 100644

--- a/third_party/WebKit/Source/devtools/front_end/ui/SuggestBox.js

+++ b/third_party/WebKit/Source/devtools/front_end/ui/SuggestBox.js

@@ -396,10 +396,10 @@ WebInspector.SuggestBox.prototype = {

keyPressed: function(event)

{

- switch (event.keyIdentifier) {

- case "Up":

+ switch (event.key) {

+ case "ArrowUp":

return this.upKeyPressed();

- case "Down":

+ case "ArrowDown":

return this.downKeyPressed();

case "PageUp":

return this.pageUpKeyPressed();