Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(334)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2025103003: ExtensionFunction: don't pass ownership of base::Value by raw pointer. (Closed)

Created:
4 years, 6 months ago by dcheng
Modified:
4 years, 6 months ago
CC:
chromium-apps-reviews_chromium.org, chromium-reviews, davemoore+watch_chromium.org, extensions-reviews_chromium.org, nona+watch_chromium.org, oshima+watch_chromium.org, rginda+watch_chromium.org, shuchen+watch_chromium.org, yusukes+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ExtensionFunction: don't pass ownership of base::Value by raw pointer. BUG=581865 R=rockot@chromium.org TBR=rdevlin.cronin@chromium.org Committed: https://crrev.com/5a01060d89daad34fa1cd8a20a0e4fdb48976a79 Cr-Commit-Position: refs/heads/master@{#397284}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+155 lines, -113 lines) Patch
M chrome/browser/chromeos/extensions/file_manager/private_api_file_system.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/private_api_misc.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/extensions/input_method_api.cc View 7 chunks +8 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/extensions/users_private/users_private_api.cc View 9 chunks +19 lines, -9 lines 0 comments Download
M chrome/browser/extensions/api/autofill_private/autofill_private_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/automation_internal/automation_internal_api.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/cryptotoken_private/cryptotoken_private_api.cc View 4 chunks +9 lines, -4 lines 0 comments Download
M chrome/browser/extensions/api/data_reduction_proxy/data_reduction_proxy_api.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/extensions/api/data_reduction_proxy/data_reduction_proxy_api.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/developer_private/developer_private_api.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/identity/identity_api.cc View 4 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/instance_id/instance_id_api.cc View 4 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/language_settings_private/language_settings_private_api.cc View 7 chunks +10 lines, -7 lines 0 comments Download
M chrome/browser/extensions/api/settings_private/settings_private_api.cc View 7 chunks +14 lines, -7 lines 0 comments Download
M chrome/browser/extensions/api/webstore_widget_private/webstore_widget_private_api.cc View 2 chunks +11 lines, -10 lines 0 comments Download
M extensions/browser/api/hid/hid_api.cc View 6 chunks +14 lines, -10 lines 0 comments Download
M extensions/browser/api/idle/idle_manager.h View 2 chunks +3 lines, -1 line 0 comments Download
M extensions/browser/api/idle/idle_manager.cc View 3 chunks +4 lines, -2 lines 0 comments Download
M extensions/browser/api/management/management_api.cc View 2 chunks +2 lines, -1 line 0 comments Download
M extensions/browser/api/runtime/runtime_api.cc View 3 chunks +7 lines, -5 lines 0 comments Download
M extensions/browser/api/storage/storage_api.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M extensions/browser/api/usb/usb_api.cc View 5 chunks +9 lines, -7 lines 0 comments Download
M extensions/browser/api/vpn_provider/vpn_provider_api.cc View 2 chunks +2 lines, -1 line 0 comments Download
M extensions/browser/extension_function.h View 2 chunks +8 lines, -13 lines 0 comments Download
M extensions/browser/extension_function.cc View 1 chunk +6 lines, -11 lines 0 comments Download
M extensions/shell/browser/api/identity/identity_api.cc View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 21 (9 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2025103003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2025103003/1
4 years, 6 months ago (2016-06-01 06:41:54 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-01 08:07:44 UTC) #4
dcheng
4 years, 6 months ago (2016-06-01 20:39:41 UTC) #6
Ken Rockot(use gerrit already)
lgtm
4 years, 6 months ago (2016-06-01 21:35:37 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2025103003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2025103003/1
4 years, 6 months ago (2016-06-01 23:08:58 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/193383)
4 years, 6 months ago (2016-06-01 23:46:29 UTC) #11
dcheng
TBRing rdevlin.cronin@ for c/b/chromeos/extensions
4 years, 6 months ago (2016-06-01 23:56:41 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2025103003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2025103003/1
4 years, 6 months ago (2016-06-01 23:58:31 UTC) #16
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-02 00:15:32 UTC) #17
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/5a01060d89daad34fa1cd8a20a0e4fdb48976a79 Cr-Commit-Position: refs/heads/master@{#397284}
4 years, 6 months ago (2016-06-02 00:16:43 UTC) #19
Devlin
lgtm
4 years, 6 months ago (2016-06-02 00:18:51 UTC) #20
dcheng
4 years, 6 months ago (2016-06-02 22:35:08 UTC) #21
Message was sent while issue was closed. 
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2038613003/ by dcheng@chromium.org.

The reason for reverting is: Speculatively reverting to fix release-blocking
crash..

Powered by Google App Engine
This is Rietveld 408576698