ExtensionFunction: don't pass ownership of base::Value by raw pointer.

chrome/browser/extensions/api/instance_id/instance_id_api.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/api/instance_id/instance_id_api.h"
 
 #include "base/logging.h"
+#include "base/memory/ptr_util.h"
 #include "base/metrics/histogram_macros.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/services/gcm/instance_id/instance_id_profile_service.h"
 #include "chrome/browser/services/gcm/instance_id/instance_id_profile_service_factory.h"
 #include "chrome/common/extensions/api/instance_id.h"
 #include "components/gcm_driver/instance_id/instance_id_driver.h"
 #include "extensions/common/extension.h"
 
 namespace extensions {
 
@@ skipping 69 matching lines @@
 
 InstanceIDGetIDFunction::~InstanceIDGetIDFunction() {}
 
 ExtensionFunction::ResponseAction InstanceIDGetIDFunction::DoWork() {
   GetInstanceID()->GetID(
       base::Bind(&InstanceIDGetIDFunction::GetIDCompleted, this));
   return RespondLater();
 }
 
 void InstanceIDGetIDFunction::GetIDCompleted(const std::string& id) {
-  Respond(OneArgument(new base::StringValue(id)));
+  Respond(OneArgument(base::MakeUnique<base::StringValue>(id)));
 }
 
 InstanceIDGetCreationTimeFunction::InstanceIDGetCreationTimeFunction() {}
 
 InstanceIDGetCreationTimeFunction::~InstanceIDGetCreationTimeFunction() {}
 
 ExtensionFunction::ResponseAction InstanceIDGetCreationTimeFunction::DoWork() {
   GetInstanceID()->GetCreationTime(
       base::Bind(&InstanceIDGetCreationTimeFunction::GetCreationTimeCompleted,
                  this));
   return RespondLater();
 }
 
 void InstanceIDGetCreationTimeFunction::GetCreationTimeCompleted(
     const base::Time& creation_time) {
-  Respond(OneArgument(new base::FundamentalValue(creation_time.ToDoubleT())));
+  Respond(OneArgument(
+      base::MakeUnique<base::FundamentalValue>(creation_time.ToDoubleT())));
 }
 
 InstanceIDGetTokenFunction::InstanceIDGetTokenFunction() {}
 
 InstanceIDGetTokenFunction::~InstanceIDGetTokenFunction() {}
 
 ExtensionFunction::ResponseAction InstanceIDGetTokenFunction::DoWork() {
   std::unique_ptr<api::instance_id::GetToken::Params> params =
       api::instance_id::GetToken::Params::Create(*args_);
   EXTENSION_FUNCTION_VALIDATE(params.get());
 
   std::map<std::string, std::string> options;
   if (params->get_token_params.options.get())
     options = params->get_token_params.options->additional_properties;
 
   GetInstanceID()->GetToken(
       params->get_token_params.authorized_entity,
       params->get_token_params.scope,
       options,
       base::Bind(&InstanceIDGetTokenFunction::GetTokenCompleted, this));
 
   return RespondLater();
 }
 
 void InstanceIDGetTokenFunction::GetTokenCompleted(
     const std::string& token,
     instance_id::InstanceID::Result result) {
   if (result == instance_id::InstanceID::SUCCESS)
-    Respond(OneArgument(new base::StringValue(token)));
+    Respond(OneArgument(base::MakeUnique<base::StringValue>(token)));
   else
     Respond(Error(InstanceIDResultToError(result)));
 }
 
 InstanceIDDeleteTokenFunction::InstanceIDDeleteTokenFunction() {}
 
 InstanceIDDeleteTokenFunction::~InstanceIDDeleteTokenFunction() {}
 
 ExtensionFunction::ResponseAction InstanceIDDeleteTokenFunction::DoWork() {
   std::unique_ptr<api::instance_id::DeleteToken::Params> params =
@@ skipping 29 matching lines @@
 
 void InstanceIDDeleteIDFunction::DeleteIDCompleted(
     instance_id::InstanceID::Result result) {
   if (result == instance_id::InstanceID::SUCCESS)
     Respond(NoArguments());
   else
     Respond(Error(InstanceIDResultToError(result)));
 }
 
 }  // namespace extensions