chrome/browser/chromeos/extensions/file_manager/private_api_misc.cc - Issue 2025103003: ExtensionFunction: don't pass ownership of base::Value by raw pointer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/extensions/file_manager/private_api_misc.cc

Issue 2025103003: ExtensionFunction: don't pass ownership of base::Value by raw pointer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/extensions/file_manager/private_api_file_system.cc ('k') | chrome/browser/chromeos/extensions/input_method_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/extensions/file_manager/private_api_misc.cc

diff --git a/chrome/browser/chromeos/extensions/file_manager/private_api_misc.cc b/chrome/browser/chromeos/extensions/file_manager/private_api_misc.cc

index 717d518d4d35bd4c09f970919abed24fec4932b5..ba822163b49e2299f5d961f4e5cf1e4048b08768 100644

--- a/chrome/browser/chromeos/extensions/file_manager/private_api_misc.cc

+++ b/chrome/browser/chromeos/extensions/file_manager/private_api_misc.cc

@@ -467,9 +467,11 @@ void FileManagerPrivateInternalGetMimeTypeFunction::OnGetMimeType(

ExtensionFunction::ResponseAction

FileManagerPrivateIsPiexLoaderEnabledFunction::Run() {

#if defined(OFFICIAL_BUILD)

- return RespondNow(OneArgument(new base::FundamentalValue(true)));

+ return RespondNow(

+ OneArgument(base::MakeUnique<base::FundamentalValue>(true)));

#else

- return RespondNow(OneArgument(new base::FundamentalValue(false)));

+ return RespondNow(

+ OneArgument(base::MakeUnique<base::FundamentalValue>(false)));

#endif

}