Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Unified Diff: chrome/browser/extensions/api/webstore_widget_private/webstore_widget_private_api.cc

Issue 2025103003: ExtensionFunction: don't pass ownership of base::Value by raw pointer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/webstore_widget_private/webstore_widget_private_api.cc
diff --git a/chrome/browser/extensions/api/webstore_widget_private/webstore_widget_private_api.cc b/chrome/browser/extensions/api/webstore_widget_private/webstore_widget_private_api.cc
index cb530c54dacc09172b2c2c4aaaeb7b4741e3388b..00e0a6f2290e24f4aa182e28996e2df739b11671 100644
--- a/chrome/browser/extensions/api/webstore_widget_private/webstore_widget_private_api.cc
+++ b/chrome/browser/extensions/api/webstore_widget_private/webstore_widget_private_api.cc
@@ -5,6 +5,7 @@
#include "chrome/browser/extensions/api/webstore_widget_private/webstore_widget_private_api.h"
#include <memory>
+#include <utility>
#include "base/values.h"
#include "chrome/browser/browser_process.h"
@@ -40,25 +41,25 @@ WebstoreWidgetPrivateGetStringsFunction::
ExtensionFunction::ResponseAction
WebstoreWidgetPrivateGetStringsFunction::Run() {
- base::DictionaryValue* dict = new base::DictionaryValue();
+ std::unique_ptr<base::DictionaryValue> dict(new base::DictionaryValue());
- SetL10nString(dict, "TITLE_PRINTER_PROVIDERS",
+ SetL10nString(dict.get(), "TITLE_PRINTER_PROVIDERS",
IDS_WEBSTORE_WIDGET_TITLE_PRINTER_PROVIDERS);
- SetL10nString(dict, "DEFAULT_ERROR_MESSAGE",
+ SetL10nString(dict.get(), "DEFAULT_ERROR_MESSAGE",
IDS_WEBSTORE_WIDGET_DEFAULT_ERROR);
- SetL10nString(dict, "OK_BUTTON", IDS_FILE_BROWSER_OK_LABEL);
- SetL10nString(dict, "INSTALLATION_FAILED_MESSAGE",
+ SetL10nString(dict.get(), "OK_BUTTON", IDS_FILE_BROWSER_OK_LABEL);
+ SetL10nString(dict.get(), "INSTALLATION_FAILED_MESSAGE",
IDS_FILE_BROWSER_SUGGEST_DIALOG_INSTALLATION_FAILED);
- SetL10nString(dict, "LINK_TO_WEBSTORE",
+ SetL10nString(dict.get(), "LINK_TO_WEBSTORE",
IDS_FILE_BROWSER_SUGGEST_DIALOG_LINK_TO_WEBSTORE);
- SetL10nString(dict, "LOADING_SPINNER_ALT",
+ SetL10nString(dict.get(), "LOADING_SPINNER_ALT",
IDS_WEBSTORE_WIDGET_LOADING_SPINNER_ALT);
- SetL10nString(dict, "INSTALLING_SPINNER_ALT",
+ SetL10nString(dict.get(), "INSTALLING_SPINNER_ALT",
IDS_WEBSTORE_WIDGET_INSTALLING_SPINNER_ALT);
const std::string& app_locale = g_browser_process->GetApplicationLocale();
- webui::SetLoadTimeDataDefaults(app_locale, dict);
- return RespondNow(OneArgument(dict));
+ webui::SetLoadTimeDataDefaults(app_locale, dict.get());
+ return RespondNow(OneArgument(std::move(dict)));
}
WebstoreWidgetPrivateInstallWebstoreItemFunction::
« no previous file with comments | « chrome/browser/extensions/api/settings_private/settings_private_api.cc ('k') | extensions/browser/api/hid/hid_api.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698