ExtensionFunction: don't pass ownership of base::Value by raw pointer.

chrome/browser/extensions/api/webstore_widget_private/webstore_widget_private_api.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/api/webstore_widget_private/webstore_widget_private_api.h"
 
 #include <memory>
+#include <utility>
 
 #include "base/values.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/chromeos/file_manager/app_id.h"
 #include "chrome/browser/extensions/api/webstore_widget_private/app_installer.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/common/extensions/api/webstore_widget_private.h"
 #include "chrome/grit/generated_resources.h"
 #include "ui/base/l10n/l10n_util.h"
 #include "ui/base/webui/web_ui_util.h"
@@ skipping 15 matching lines @@
 WebstoreWidgetPrivateGetStringsFunction::
     WebstoreWidgetPrivateGetStringsFunction() {
 }
 
 WebstoreWidgetPrivateGetStringsFunction::
     ~WebstoreWidgetPrivateGetStringsFunction() {
 }
 
 ExtensionFunction::ResponseAction
 WebstoreWidgetPrivateGetStringsFunction::Run() {
-  base::DictionaryValue* dict = new base::DictionaryValue();
+  std::unique_ptr<base::DictionaryValue> dict(new base::DictionaryValue());
 
-  SetL10nString(dict, "TITLE_PRINTER_PROVIDERS",
+  SetL10nString(dict.get(), "TITLE_PRINTER_PROVIDERS",
                 IDS_WEBSTORE_WIDGET_TITLE_PRINTER_PROVIDERS);
-  SetL10nString(dict, "DEFAULT_ERROR_MESSAGE",
+  SetL10nString(dict.get(), "DEFAULT_ERROR_MESSAGE",
                 IDS_WEBSTORE_WIDGET_DEFAULT_ERROR);
-  SetL10nString(dict, "OK_BUTTON", IDS_FILE_BROWSER_OK_LABEL);
-  SetL10nString(dict, "INSTALLATION_FAILED_MESSAGE",
+  SetL10nString(dict.get(), "OK_BUTTON", IDS_FILE_BROWSER_OK_LABEL);
+  SetL10nString(dict.get(), "INSTALLATION_FAILED_MESSAGE",
                 IDS_FILE_BROWSER_SUGGEST_DIALOG_INSTALLATION_FAILED);
-  SetL10nString(dict, "LINK_TO_WEBSTORE",
+  SetL10nString(dict.get(), "LINK_TO_WEBSTORE",
                 IDS_FILE_BROWSER_SUGGEST_DIALOG_LINK_TO_WEBSTORE);
-  SetL10nString(dict, "LOADING_SPINNER_ALT",
+  SetL10nString(dict.get(), "LOADING_SPINNER_ALT",
                 IDS_WEBSTORE_WIDGET_LOADING_SPINNER_ALT);
-  SetL10nString(dict, "INSTALLING_SPINNER_ALT",
+  SetL10nString(dict.get(), "INSTALLING_SPINNER_ALT",
                 IDS_WEBSTORE_WIDGET_INSTALLING_SPINNER_ALT);
 
   const std::string& app_locale = g_browser_process->GetApplicationLocale();
-  webui::SetLoadTimeDataDefaults(app_locale, dict);
-  return RespondNow(OneArgument(dict));
+  webui::SetLoadTimeDataDefaults(app_locale, dict.get());
+  return RespondNow(OneArgument(std::move(dict)));
 }
 
 WebstoreWidgetPrivateInstallWebstoreItemFunction::
     WebstoreWidgetPrivateInstallWebstoreItemFunction() {
 }
 
 WebstoreWidgetPrivateInstallWebstoreItemFunction::
     ~WebstoreWidgetPrivateInstallWebstoreItemFunction() {
 }
 
@@ skipping 33 matching lines @@
     const std::string& error,
     extensions::webstore_install::Result result) {
   if (!success)
     SetError(error);
 
   SendResponse(success);
 }
 
 }  // namespace api
 }  // namespace extensions