chrome/browser/chromeos/extensions/file_manager/private_api_file_system.cc - Issue 2025103003: ExtensionFunction: don't pass ownership of base::Value by raw pointer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/extensions/file_manager/private_api_file_system.cc

Issue 2025103003: ExtensionFunction: don't pass ownership of base::Value by raw pointer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/chromeos/extensions/file_manager/private_api_file_system.cc

diff --git a/chrome/browser/chromeos/extensions/file_manager/private_api_file_system.cc b/chrome/browser/chromeos/extensions/file_manager/private_api_file_system.cc

index 2d0b1831946ad0391559ab6a7212a004cf718b47..23f204a4043b6c092dc54d86a2dcb85aad85abcd 100644

--- a/chrome/browser/chromeos/extensions/file_manager/private_api_file_system.cc

+++ b/chrome/browser/chromeos/extensions/file_manager/private_api_file_system.cc

@@ -945,7 +945,7 @@ void FileManagerPrivateSearchFilesByHashesFunction::OnSearchByHashes(

ExtensionFunction::ResponseAction

FileManagerPrivateIsUMAEnabledFunction::Run() {

- return RespondNow(OneArgument(new base::FundamentalValue(

+ return RespondNow(OneArgument(base::MakeUnique<base::FundamentalValue>(

ChromeMetricsServiceAccessor::IsMetricsAndCrashReportingEnabled())));

}

« no previous file with comments | « no previous file | chrome/browser/chromeos/extensions/file_manager/private_api_misc.cc » ('j') | no next file with comments »