Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(371)

Side by Side Diff: chrome/browser/extensions/api/data_reduction_proxy/data_reduction_proxy_api.cc

Issue 2025103003: ExtensionFunction: don't pass ownership of base::Value by raw pointer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/extensions/api/data_reduction_proxy/data_reduction_prox y_api.h" 5 #include "chrome/browser/extensions/api/data_reduction_proxy/data_reduction_prox y_api.h"
6 6
7 #include <utility> 7 #include <utility>
8 #include <vector> 8 #include <vector>
9 9
10 #include "chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings.h" 10 #include "chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings.h"
(...skipping 45 matching lines...) Expand 10 before | Expand all | Expand 10 after
56 usage->SetString("hostname", site_usage.hostname()); 56 usage->SetString("hostname", site_usage.hostname());
57 usage->SetDouble("data_used", site_usage.data_used()); 57 usage->SetDouble("data_used", site_usage.data_used());
58 usage->SetDouble("original_size", site_usage.original_size()); 58 usage->SetDouble("original_size", site_usage.original_size());
59 site_usage_list->Append(std::move(usage)); 59 site_usage_list->Append(std::move(usage));
60 } 60 }
61 connection_usage_list->Append(std::move(site_usage_list)); 61 connection_usage_list->Append(std::move(site_usage_list));
62 } 62 }
63 data_usage_buckets->Append(std::move(connection_usage_list)); 63 data_usage_buckets->Append(std::move(connection_usage_list));
64 } 64 }
65 65
66 base::DictionaryValue* result = new base::DictionaryValue(); 66 std::unique_ptr<base::DictionaryValue> result(new base::DictionaryValue());
67 result->Set("data_usage_buckets", std::move(data_usage_buckets)); 67 result->Set("data_usage_buckets", std::move(data_usage_buckets));
68 Respond(OneArgument(result)); 68 Respond(OneArgument(std::move(result)));
69 } 69 }
70 70
71 } // namespace extensions 71 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698