chrome/browser/extensions/api/automation_internal/automation_internal_api.cc - Issue 2025103003: ExtensionFunction: don't pass ownership of base::Value by raw pointer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/automation_internal/automation_internal_api.cc

Issue 2025103003: ExtensionFunction: don't pass ownership of base::Value by raw pointer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/autofill_private/autofill_private_api.cc ('k') | chrome/browser/extensions/api/cryptotoken_private/cryptotoken_private_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/automation_internal/automation_internal_api.cc

diff --git a/chrome/browser/extensions/api/automation_internal/automation_internal_api.cc b/chrome/browser/extensions/api/automation_internal/automation_internal_api.cc

index c826529e85bb8b674c345f80ccba35e4927e62bb..841b05508d26420c5a1b069bb32717a3a49c8543 100644

--- a/chrome/browser/extensions/api/automation_internal/automation_internal_api.cc

+++ b/chrome/browser/extensions/api/automation_internal/automation_internal_api.cc

@@ -9,6 +9,7 @@

#include <vector>

#include "base/macros.h"

+#include "base/memory/ptr_util.h"

#include "base/strings/string16.h"

#include "base/strings/string_number_conversions.h"

#include "base/strings/utf_string_conversions.h"

@@ -448,7 +449,8 @@ void AutomationInternalQuerySelectorFunction::OnResponse(

return;

}

- Respond(OneArgument(new base::FundamentalValue(result_acc_obj_id)));

+ Respond(

+ OneArgument(base::MakeUnique<base::FundamentalValue>(result_acc_obj_id)));

}

} // namespace extensions