chrome/browser/extensions/api/data_reduction_proxy/data_reduction_proxy_api.h - Issue 2025103003: ExtensionFunction: don't pass ownership of base::Value by raw pointer.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/extensions/api/data_reduction_proxy/data_reduction_proxy_api.h

Issue 2025103003: ExtensionFunction: don't pass ownership of base::Value by raw pointer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/browser/extensions/api/cryptotoken_private/cryptotoken_private_api.cc ('k') | chrome/browser/extensions/api/data_reduction_proxy/data_reduction_proxy_api.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2015 The Chromium Authors. All rights reserved.	1 // Copyright 2015 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef CHROME_BROWSER_EXTENSIONS_API_DATA_REDUCTION_PROXY_DATA_REDUCTION_PROXY_ API_H_	5 #ifndef CHROME_BROWSER_EXTENSIONS_API_DATA_REDUCTION_PROXY_DATA_REDUCTION_PROXY_ API_H_

6 #define CHROME_BROWSER_EXTENSIONS_API_DATA_REDUCTION_PROXY_DATA_REDUCTION_PROXY_ API_H_	6 #define CHROME_BROWSER_EXTENSIONS_API_DATA_REDUCTION_PROXY_DATA_REDUCTION_PROXY_ API_H_

7	7

	8 #include <memory>

	9

8 #include "extensions/browser/extension_function.h"	10 #include "extensions/browser/extension_function.h"

9	11

10 namespace data_reduction_proxy {	12 namespace data_reduction_proxy {

11 class DataUsageBucket;	13 class DataUsageBucket;

12 }	14 }

13	15

14 namespace extensions {	16 namespace extensions {

15	17

16 class DataReductionProxyClearDataSavingsFunction	18 class DataReductionProxyClearDataSavingsFunction

17 : public UIThreadExtensionFunction {	19 : public UIThreadExtensionFunction {

(...skipping 17 matching lines...) Expand all Loading...
35 ResponseAction Run() override;	37 ResponseAction Run() override;

36	38

37 void ReplyWithDataUsage(	39 void ReplyWithDataUsage(

38 std::unique_ptr<std::vector<data_reduction_proxy::DataUsageBucket>>	40 std::unique_ptr<std::vector<data_reduction_proxy::DataUsageBucket>>

39 data_usage);	41 data_usage);

40 };	42 };

41	43

42 } // namespace extensions	44 } // namespace extensions

43	45

44 #endif // CHROME_BROWSER_EXTENSIONS_API_DATA_REDUCTION_PROXY_DATA_REDUCTION_PRO XY_API_H_	46 #endif // CHROME_BROWSER_EXTENSIONS_API_DATA_REDUCTION_PROXY_DATA_REDUCTION_PRO XY_API_H_

OLD	NEW