extensions/browser/api/vpn_provider/vpn_provider_api.cc - Issue 2025103003: ExtensionFunction: don't pass ownership of base::Value by raw pointer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/vpn_provider/vpn_provider_api.cc

Issue 2025103003: ExtensionFunction: don't pass ownership of base::Value by raw pointer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: extensions/browser/api/vpn_provider/vpn_provider_api.cc

diff --git a/extensions/browser/api/vpn_provider/vpn_provider_api.cc b/extensions/browser/api/vpn_provider/vpn_provider_api.cc

index 5856f3deff579176a8024bdef2d7f4b86773fabc..5f58f3214c8a2455e6f685d683339eeed4be6354 100644

--- a/extensions/browser/api/vpn_provider/vpn_provider_api.cc

+++ b/extensions/browser/api/vpn_provider/vpn_provider_api.cc

@@ -9,6 +9,7 @@

#include "base/bind.h"

#include "base/logging.h"

+#include "base/memory/ptr_util.h"

#include "base/strings/string_split.h"

#include "base/strings/string_util.h"

#include "base/values.h"

@@ -162,7 +163,7 @@ void VpnThreadExtensionFunction::SignalCallCompletionSuccess() {

void VpnThreadExtensionFunction::SignalCallCompletionSuccessWithId(

const std::string& configuration_id) {

- Respond(OneArgument(new base::StringValue(configuration_id)));

+ Respond(OneArgument(base::MakeUnique<base::StringValue>(configuration_id)));

}

void VpnThreadExtensionFunction::SignalCallCompletionSuccessWithWarning(

« no previous file with comments | « extensions/browser/api/usb/usb_api.cc ('k') | extensions/browser/extension_function.h » ('j') | no next file with comments »