ExtensionFunction: don't pass ownership of base::Value by raw pointer.

chrome/browser/extensions/api/identity/identity_api.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/api/identity/identity_api.h"
 
 #include <stddef.h>
 
+#include <memory>
 #include <set>
 #include <string>
 #include <utility>
 #include <vector>
 
 #include "base/lazy_instance.h"
 #include "base/macros.h"
 #include "base/memory/ptr_util.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/stringprintf.h"
@@ skipping 266 matching lines @@
 
 ExtensionFunction::ResponseAction IdentityGetAccountsFunction::Run() {
   if (GetProfile()->IsOffTheRecord()) {
     return RespondNow(Error(identity_constants::kOffTheRecord));
   }
 
   std::vector<std::string> gaia_ids =
       IdentityAPI::GetFactoryInstance()->Get(GetProfile())->GetAccounts();
   DCHECK(gaia_ids.size() < 2 || switches::IsExtensionsMultiAccount());
 
-  base::ListValue* infos = new base::ListValue();
+  std::unique_ptr<base::ListValue> infos(new base::ListValue());
 
   for (std::vector<std::string>::const_iterator it = gaia_ids.begin();
        it != gaia_ids.end();
        ++it) {
     api::identity::AccountInfo account_info;
     account_info.id = *it;
     infos->Append(account_info.ToValue().release());
   }
 
-  return RespondNow(OneArgument(infos));
+  return RespondNow(OneArgument(std::move(infos)));
 }
 
 IdentityGetAuthTokenFunction::IdentityGetAuthTokenFunction()
     : OAuth2TokenService::Consumer("extensions_identity_api"),
       interactive_(false),
       should_prompt_for_scopes_(false),
       should_prompt_for_signin_(false) {
 }
 
 IdentityGetAuthTokenFunction::~IdentityGetAuthTokenFunction() {
@@ skipping 594 matching lines @@
   AccountInfo account =
       AccountTrackerServiceFactory::GetForProfile(GetProfile())
           ->GetAccountInfo(GetPrimaryAccountId(GetProfile()));
   api::identity::ProfileUserInfo profile_user_info;
   if (extension()->permissions_data()->HasAPIPermission(
           APIPermission::kIdentityEmail)) {
     profile_user_info.email = account.email;
     profile_user_info.id = account.gaia;
   }
 
-  return RespondNow(OneArgument(profile_user_info.ToValue().release()));
+  return RespondNow(OneArgument(profile_user_info.ToValue()));
 }
 
 IdentityRemoveCachedAuthTokenFunction::IdentityRemoveCachedAuthTokenFunction() {
 }
 
 IdentityRemoveCachedAuthTokenFunction::
     ~IdentityRemoveCachedAuthTokenFunction() {
 }
 
 bool IdentityRemoveCachedAuthTokenFunction::RunSync() {
@@ skipping 84 matching lines @@
   if (redirect_url.GetWithEmptyPath() == final_url_prefix_) {
     SetResult(base::MakeUnique<base::StringValue>(redirect_url.spec()));
     SendResponse(true);
     if (auth_flow_)
       auth_flow_.release()->DetachDelegateAndDelete();
     Release();  // Balanced in RunAsync.
   }
 }
 
 }  // namespace extensions