Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Issue 1976443005: Revert of Add best-effort/allow rollback flags on WorkItem. (Closed)

Created:
4 years, 7 months ago by hans
Modified:
4 years, 7 months ago
CC:
chromium-reviews, grt+watch_chromium.org, wfh+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@simple_list_tests
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add best-effort/allow rollback flags on WorkItem. (patchset #11 id:200001 of https://codereview.chromium.org/1882923003/ ) Reason for revert: This broke the build: ..\..\chrome\installer\setup\app_launcher_installer.cc(52,9): error: no member named 'set_ignore_failure' in 'WorkItem' ->set_ignore_failure(true); ^ Original issue's description: > Add best-effort/allow rollback flags on WorkItem. > > When the best-effort flag is set to true, Do() always return true > (i.e. it will never cause failure of its parent WorkItemList). > > When the allow rollback flag is set to false, Rollback() is a no-op. > > BUG=601936 > > Committed: https://crrev.com/e63a3064da66ff91ca8cccbb0c279185b0b93321 > Cr-Commit-Position: refs/heads/master@{#393652} TBR=grt@chromium.org,stgao@chromium.org,fdoray@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=601936 Committed: https://crrev.com/3fa7e2581d1da516a99020c1a4a8ef6d414313ad Cr-Commit-Position: refs/heads/master@{#393736}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+686 lines, -494 lines) Patch
M chrome/chrome_installer.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/installer/setup/install.cc View 1 chunk +3 lines, -6 lines 0 comments Download
M chrome/installer/setup/install_worker.h View 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/installer/setup/install_worker.cc View 6 chunks +12 lines, -16 lines 0 comments Download
M chrome/installer/setup/install_worker_unittest.cc View 2 chunks +6 lines, -1 line 0 comments Download
M chrome/installer/setup/setup_main.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/installer/setup/uninstall.cc View 3 chunks +10 lines, -15 lines 0 comments Download
M chrome/installer/setup/update_active_setup_version_work_item.h View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/installer/setup/update_active_setup_version_work_item.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M chrome/installer/util/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/installer/util/callback_work_item.h View 2 chunks +4 lines, -6 lines 0 comments Download
M chrome/installer/util/callback_work_item.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/installer/util/conditional_work_item_list.h View 1 chunk +3 lines, -5 lines 0 comments Download
M chrome/installer/util/conditional_work_item_list.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/installer/util/conditional_work_item_list_unittest.cc View 2 chunks +10 lines, -10 lines 0 comments Download
M chrome/installer/util/copy_tree_work_item.h View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/installer/util/copy_tree_work_item.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/installer/util/create_dir_work_item.h View 1 chunk +7 lines, -8 lines 0 comments Download
M chrome/installer/util/create_dir_work_item.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/installer/util/create_reg_key_work_item.h View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/installer/util/create_reg_key_work_item.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/installer/util/delete_reg_key_work_item.h View 2 chunks +4 lines, -7 lines 0 comments Download
M chrome/installer/util/delete_reg_key_work_item.cc View 1 chunk +12 lines, -10 lines 0 comments Download
M chrome/installer/util/delete_reg_value_work_item.h View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/installer/util/delete_reg_value_work_item.cc View 4 chunks +11 lines, -10 lines 0 comments Download
M chrome/installer/util/delete_tree_work_item.h View 4 chunks +26 lines, -8 lines 0 comments Download
M chrome/installer/util/delete_tree_work_item.cc View 1 chunk +132 lines, -12 lines 0 comments Download
M chrome/installer/util/delete_tree_work_item_unittest.cc View 1 chunk +195 lines, -73 lines 0 comments Download
M chrome/installer/util/install_util.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/installer/util/install_util.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/installer/util/installer_state.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M chrome/installer/util/move_tree_work_item.h View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/installer/util/move_tree_work_item.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/installer/util/self_reg_work_item.h View 2 chunks +3 lines, -4 lines 0 comments Download
M chrome/installer/util/self_reg_work_item.cc View 1 chunk +9 lines, -4 lines 0 comments Download
M chrome/installer/util/set_reg_value_work_item.h View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/installer/util/set_reg_value_work_item.cc View 2 chunks +20 lines, -11 lines 0 comments Download
M chrome/installer/util/work_item.h View 4 chunks +34 lines, -51 lines 0 comments Download
M chrome/installer/util/work_item.cc View 4 chunks +13 lines, -29 lines 0 comments Download
M chrome/installer/util/work_item_list.h View 4 chunks +43 lines, -13 lines 0 comments Download
M chrome/installer/util/work_item_list.cc View 4 chunks +62 lines, -19 lines 0 comments Download
M chrome/installer/util/work_item_list_unittest.cc View 2 chunks +10 lines, -10 lines 0 comments Download
M chrome/installer/util/work_item_mocks.h View 1 chunk +2 lines, -2 lines 0 comments Download
D chrome/installer/util/work_item_unittest.cc View 1 chunk +0 lines, -104 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
hans
Created Revert of Add best-effort/allow rollback flags on WorkItem.
4 years, 7 months ago (2016-05-14 19:55:14 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1976443005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1976443005/1
4 years, 7 months ago (2016-05-14 19:55:41 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-14 19:57:46 UTC) #4
commit-bot: I haz the power
4 years, 7 months ago (2016-05-14 19:59:00 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3fa7e2581d1da516a99020c1a4a8ef6d414313ad
Cr-Commit-Position: refs/heads/master@{#393736}

Powered by Google App Engine
This is Rietveld 408576698