chrome/installer/util/install_util.cc - Issue 1976443005: Revert of Add best-effort/allow rollback flags on WorkItem.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/installer/util/install_util.cc

Issue 1976443005: Revert of Add best-effort/allow rollback flags on WorkItem. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@simple_list_tests

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/installer/util/install_util.cc

diff --git a/chrome/installer/util/install_util.cc b/chrome/installer/util/install_util.cc

index c5568048da4978a6a33234dc036ac5228fa95b7e..8b6dfa75deab255b214ff5e749ab7e76949ad6a7 100644

--- a/chrome/installer/util/install_util.cc

+++ b/chrome/installer/util/install_util.cc

@@ -285,9 +285,6 @@

const base::string16* const launch_cmd,

WorkItemList* install_list) {

DCHECK(install_list);

- DCHECK(install_list->best_effort());

- DCHECK(!install_list->rollback_enabled());

const HKEY root = system_install ? HKEY_LOCAL_MACHINE : HKEY_CURRENT_USER;

DWORD installer_result = (GetInstallReturnCode(status) == 0) ? 0 : 1;

install_list->AddCreateRegKeyWorkItem(root, state_key, KEY_WOW64_32KEY);

« no previous file with comments | « chrome/installer/util/install_util.h ('k') | chrome/installer/util/installer_state.cc » ('j') | no next file with comments »