Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Side by Side Diff: chrome/installer/util/callback_work_item.h

Issue 1976443005: Revert of Add best-effort/allow rollback flags on WorkItem. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@simple_list_tests
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/installer/util/BUILD.gn ('k') | chrome/installer/util/callback_work_item.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_INSTALLER_UTIL_CALLBACK_WORK_ITEM_H_ 5 #ifndef CHROME_INSTALLER_UTIL_CALLBACK_WORK_ITEM_H_
6 #define CHROME_INSTALLER_UTIL_CALLBACK_WORK_ITEM_H_ 6 #define CHROME_INSTALLER_UTIL_CALLBACK_WORK_ITEM_H_
7 7
8 #include "base/callback.h" 8 #include "base/callback.h"
9 #include "base/compiler_specific.h" 9 #include "base/compiler_specific.h"
10 #include "base/gtest_prod_util.h" 10 #include "base/gtest_prod_util.h"
(...skipping 17 matching lines...) Expand all
28 // 28 //
29 // void SomeFunctionThatAddsItemsToAList(WorkItemList* item_list) { 29 // void SomeFunctionThatAddsItemsToAList(WorkItemList* item_list) {
30 // ... 30 // ...
31 // item_list->AddCallbackWorkItem(base::Bind(&SomeWorkItemCallback)); 31 // item_list->AddCallbackWorkItem(base::Bind(&SomeWorkItemCallback));
32 // ... 32 // ...
33 // } 33 // }
34 class CallbackWorkItem : public WorkItem { 34 class CallbackWorkItem : public WorkItem {
35 public: 35 public:
36 ~CallbackWorkItem() override; 36 ~CallbackWorkItem() override;
37 37
38 bool Do() override;
39 void Rollback() override;
40
38 bool IsRollback() const; 41 bool IsRollback() const;
39 42
40 private: 43 private:
41 friend class WorkItem; 44 friend class WorkItem;
42 45
43 enum RollState { 46 enum RollState {
44 RS_UNDEFINED, 47 RS_UNDEFINED,
45 RS_FORWARD, 48 RS_FORWARD,
46 RS_BACKWARD, 49 RS_BACKWARD,
47 }; 50 };
48 51
49 explicit CallbackWorkItem( 52 CallbackWorkItem(base::Callback<bool(const CallbackWorkItem&)> callback);
50 base::Callback<bool(const CallbackWorkItem&)> callback);
51
52 // WorkItem:
53 bool DoImpl() override;
54 void RollbackImpl() override;
55 53
56 base::Callback<bool(const CallbackWorkItem&)> callback_; 54 base::Callback<bool(const CallbackWorkItem&)> callback_;
57 RollState roll_state_; 55 RollState roll_state_;
58 56
59 FRIEND_TEST_ALL_PREFIXES(CallbackWorkItemTest, TestFailure); 57 FRIEND_TEST_ALL_PREFIXES(CallbackWorkItemTest, TestFailure);
60 FRIEND_TEST_ALL_PREFIXES(CallbackWorkItemTest, TestForwardBackward); 58 FRIEND_TEST_ALL_PREFIXES(CallbackWorkItemTest, TestForwardBackward);
61 }; 59 };
62 60
63 #endif // CHROME_INSTALLER_UTIL_CALLBACK_WORK_ITEM_H_ 61 #endif // CHROME_INSTALLER_UTIL_CALLBACK_WORK_ITEM_H_
OLDNEW
« no previous file with comments | « chrome/installer/util/BUILD.gn ('k') | chrome/installer/util/callback_work_item.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698