chrome/installer/util/callback_work_item.cc - Issue 1976443005: Revert of Add best-effort/allow rollback flags on WorkItem.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/installer/util/callback_work_item.cc

Issue 1976443005: Revert of Add best-effort/allow rollback flags on WorkItem. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@simple_list_tests

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/installer/util/callback_work_item.cc

diff --git a/chrome/installer/util/callback_work_item.cc b/chrome/installer/util/callback_work_item.cc

index 34376eab71e5388f73ef2cadb2621c0b583c5c24..e2dbbec3ab9f89744c3f444764938d86cf119cd0 100644

--- a/chrome/installer/util/callback_work_item.cc

+++ b/chrome/installer/util/callback_work_item.cc

@@ -17,7 +17,7 @@

CallbackWorkItem::~CallbackWorkItem() {

}

-bool CallbackWorkItem::DoImpl() {

+bool CallbackWorkItem::Do() {

DCHECK_EQ(roll_state_, RS_UNDEFINED);

roll_state_ = RS_FORWARD;

@@ -27,7 +27,7 @@

return result;

}

-void CallbackWorkItem::RollbackImpl() {

+void CallbackWorkItem::Rollback() {

DCHECK_EQ(roll_state_, RS_UNDEFINED);

roll_state_ = RS_BACKWARD;

« no previous file with comments | « chrome/installer/util/callback_work_item.h ('k') | chrome/installer/util/conditional_work_item_list.h » ('j') | no next file with comments »