Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8855)

Unified Diff: chrome/installer/util/set_reg_value_work_item.h

Issue 1976443005: Revert of Add best-effort/allow rollback flags on WorkItem. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@simple_list_tests
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/installer/util/self_reg_work_item.cc ('k') | chrome/installer/util/set_reg_value_work_item.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/installer/util/set_reg_value_work_item.h
diff --git a/chrome/installer/util/set_reg_value_work_item.h b/chrome/installer/util/set_reg_value_work_item.h
index c8fdc2b8b935706915f49e46910e56f60fab0fe5..60104c4e9c89133231adac143a241456c73f498a 100644
--- a/chrome/installer/util/set_reg_value_work_item.h
+++ b/chrome/installer/util/set_reg_value_work_item.h
@@ -49,6 +49,10 @@
~SetRegValueWorkItem() override;
+ bool Do() override;
+
+ void Rollback() override;
+
private:
enum SettingStatus {
// The status before Do is called.
@@ -65,10 +69,6 @@
// The status after Do and Rollback is called.
VALUE_ROLL_BACK
};
-
- // WorkItem:
- bool DoImpl() override;
- void RollbackImpl() override;
// Root key of the target key under which the value is set. The root key can
// only be one of the predefined keys on Windows.
« no previous file with comments | « chrome/installer/util/self_reg_work_item.cc ('k') | chrome/installer/util/set_reg_value_work_item.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698