chrome/installer/setup/install.cc - Issue 1976443005: Revert of Add best-effort/allow rollback flags on WorkItem.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/installer/setup/install.cc

Issue 1976443005: Revert of Add best-effort/allow rollback flags on WorkItem. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@simple_list_tests

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/installer/setup/install.cc

diff --git a/chrome/installer/setup/install.cc b/chrome/installer/setup/install.cc

index 43a8ed24c7cd20bb00b3cb62f5f652e166e2e66a..af9662322892c2eaff4361005cd3f522f3cc7383 100644

--- a/chrome/installer/setup/install.cc

+++ b/chrome/installer/setup/install.cc

@@ -756,12 +756,9 @@

bool force) {

DCHECK(chrome.is_chrome());

- std::unique_ptr<WorkItemList> cleanup_list(WorkItem::CreateWorkItemList());

- cleanup_list->set_log_message("Cleanup deprecated per-user registrations");

- cleanup_list->set_rollback_enabled(false);

- cleanup_list->set_best_effort(true);

- AddCleanupDeprecatedPerUserRegistrationsWorkItems(chrome, cleanup_list.get());

- cleanup_list->Do();

+ NoRollbackWorkItemList cleanup_list;

+ AddCleanupDeprecatedPerUserRegistrationsWorkItems(chrome, &cleanup_list);

+ cleanup_list.Do();

// Only create shortcuts on Active Setup if the first run sentinel is not

// present for this user (as some shortcuts used to be installed on first

« no previous file with comments | « chrome/chrome_installer.gypi ('k') | chrome/installer/setup/install_worker.h » ('j') | no next file with comments »