Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(683)

Side by Side Diff: chrome/installer/setup/update_active_setup_version_work_item.h

Issue 1976443005: Revert of Add best-effort/allow rollback flags on WorkItem. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@simple_list_tests
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_INSTALLER_SETUP_UPDATE_ACTIVE_SETUP_VERSION_WORK_ITEM_H_ 5 #ifndef CHROME_INSTALLER_SETUP_UPDATE_ACTIVE_SETUP_VERSION_WORK_ITEM_H_
6 #define CHROME_INSTALLER_SETUP_UPDATE_ACTIVE_SETUP_VERSION_WORK_ITEM_H_ 6 #define CHROME_INSTALLER_SETUP_UPDATE_ACTIVE_SETUP_VERSION_WORK_ITEM_H_
7 7
8 #include "base/macros.h" 8 #include "base/macros.h"
9 #include "base/strings/string16.h" 9 #include "base/strings/string16.h"
10 #include "chrome/installer/util/set_reg_value_work_item.h" 10 #include "chrome/installer/util/set_reg_value_work_item.h"
(...skipping 25 matching lines...) Expand all
36 // (will default to 1 if the version was absent or invalid). 36 // (will default to 1 if the version was absent or invalid).
37 UPDATE_AND_BUMP_OS_UPGRADES_COMPONENT, 37 UPDATE_AND_BUMP_OS_UPGRADES_COMPONENT,
38 }; 38 };
39 39
40 // Constructs an UpdateActiveSetupVersionWorkItem that will perform 40 // Constructs an UpdateActiveSetupVersionWorkItem that will perform
41 // |operation| on the |active_setup_path| key in the registry. This key needs 41 // |operation| on the |active_setup_path| key in the registry. This key needs
42 // to exist when this WorkItem is ran. 42 // to exist when this WorkItem is ran.
43 UpdateActiveSetupVersionWorkItem(const base::string16& active_setup_path, 43 UpdateActiveSetupVersionWorkItem(const base::string16& active_setup_path,
44 Operation operation); 44 Operation operation);
45 45
46 // Overriden from WorkItem.
47 bool Do() override;
48 void Rollback() override;
49
46 private: 50 private:
47 // WorkItem:
48 bool DoImpl() override;
49 void RollbackImpl() override;
50
51 // Returns the updated Active Setup version to be used based on the 51 // Returns the updated Active Setup version to be used based on the
52 // |existing_version|. 52 // |existing_version|.
53 base::string16 GetUpdatedActiveSetupVersion( 53 base::string16 GetUpdatedActiveSetupVersion(
54 const base::string16& existing_version); 54 const base::string16& existing_version);
55 55
56 // The underlying WorkItem re-used to operate forward and backward on the 56 // The underlying WorkItem re-used to operate forward and backward on the
57 // registry. 57 // registry.
58 SetRegValueWorkItem set_reg_value_work_item_; 58 SetRegValueWorkItem set_reg_value_work_item_;
59 59
60 // The Operation to be performed by this WorkItem when executed. 60 // The Operation to be performed by this WorkItem when executed.
61 const Operation operation_; 61 const Operation operation_;
62 62
63 DISALLOW_COPY_AND_ASSIGN(UpdateActiveSetupVersionWorkItem); 63 DISALLOW_COPY_AND_ASSIGN(UpdateActiveSetupVersionWorkItem);
64 }; 64 };
65 65
66 #endif // CHROME_INSTALLER_SETUP_UPDATE_ACTIVE_SETUP_VERSION_WORK_ITEM_H_ 66 #endif // CHROME_INSTALLER_SETUP_UPDATE_ACTIVE_SETUP_VERSION_WORK_ITEM_H_
OLDNEW
« no previous file with comments | « chrome/installer/setup/uninstall.cc ('k') | chrome/installer/setup/update_active_setup_version_work_item.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698