chrome/installer/setup/update_active_setup_version_work_item.h - Issue 1976443005: Revert of Add best-effort/allow rollback flags on WorkItem.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/installer/setup/update_active_setup_version_work_item.h

Issue 1976443005: Revert of Add best-effort/allow rollback flags on WorkItem. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@simple_list_tests

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/installer/setup/update_active_setup_version_work_item.h

diff --git a/chrome/installer/setup/update_active_setup_version_work_item.h b/chrome/installer/setup/update_active_setup_version_work_item.h

index 2a7fb525f886aa49a379631fb3fd5211c5220d8f..bb962aca87a098e8791fa459c91bdc59402d49c1 100644

--- a/chrome/installer/setup/update_active_setup_version_work_item.h

+++ b/chrome/installer/setup/update_active_setup_version_work_item.h

@@ -43,11 +43,11 @@

UpdateActiveSetupVersionWorkItem(const base::string16& active_setup_path,

Operation operation);

+ // Overriden from WorkItem.

+ bool Do() override;

+ void Rollback() override;

private:

- // WorkItem:

- bool DoImpl() override;

- void RollbackImpl() override;

// Returns the updated Active Setup version to be used based on the

// |existing_version|.

base::string16 GetUpdatedActiveSetupVersion(

« no previous file with comments | « chrome/installer/setup/uninstall.cc ('k') | chrome/installer/setup/update_active_setup_version_work_item.cc » ('j') | no next file with comments »