Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4314)

Unified Diff: chrome/installer/util/self_reg_work_item.cc

Issue 1976443005: Revert of Add best-effort/allow rollback flags on WorkItem. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@simple_list_tests
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/installer/util/self_reg_work_item.h ('k') | chrome/installer/util/set_reg_value_work_item.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/installer/util/self_reg_work_item.cc
diff --git a/chrome/installer/util/self_reg_work_item.cc b/chrome/installer/util/self_reg_work_item.cc
index dc7e722110626da20a0dae93b3d58ec5c1062cae..7157d6e4ae0935aeda063f4f17164bd329b0cd2d 100644
--- a/chrome/installer/util/self_reg_work_item.cc
+++ b/chrome/installer/util/self_reg_work_item.cc
@@ -90,10 +90,15 @@
return success;
}
-bool SelfRegWorkItem::DoImpl() {
- return RegisterDll(do_register_);
+bool SelfRegWorkItem::Do() {
+ bool success = RegisterDll(do_register_);
+ if (ignore_failure_)
+ success = true;
+ return success;
}
-void SelfRegWorkItem::RollbackImpl() {
- RegisterDll(!do_register_);
+void SelfRegWorkItem::Rollback() {
+ if (!ignore_failure_) {
+ RegisterDll(!do_register_);
+ }
}
« no previous file with comments | « chrome/installer/util/self_reg_work_item.h ('k') | chrome/installer/util/set_reg_value_work_item.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698