Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1768)

Unified Diff: chrome/installer/util/copy_tree_work_item.h

Issue 1976443005: Revert of Add best-effort/allow rollback flags on WorkItem. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@simple_list_tests
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/installer/util/copy_tree_work_item.h
diff --git a/chrome/installer/util/copy_tree_work_item.h b/chrome/installer/util/copy_tree_work_item.h
index dbfdfcc24ad34a0695af6a35a1d15749767edc0a..9aa426a95fca9c948f4aeb1493150c61d127b65d 100644
--- a/chrome/installer/util/copy_tree_work_item.h
+++ b/chrome/installer/util/copy_tree_work_item.h
@@ -27,6 +27,10 @@
public:
~CopyTreeWorkItem() override;
+ bool Do() override;
+
+ void Rollback() override;
+
private:
friend class WorkItem;
@@ -40,10 +44,6 @@
const base::FilePath& temp_dir,
CopyOverWriteOption overwrite_option,
const base::FilePath& alternative_path);
-
- // WorkItem:
- bool DoImpl() override;
- void RollbackImpl() override;
// Checks if the path specified is in use (and hence can not be deleted)
bool IsFileInUse(const base::FilePath& path);
« no previous file with comments | « chrome/installer/util/conditional_work_item_list_unittest.cc ('k') | chrome/installer/util/copy_tree_work_item.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698