Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5058)

Unified Diff: chrome/installer/util/create_dir_work_item.h

Issue 1976443005: Revert of Add best-effort/allow rollback flags on WorkItem. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@simple_list_tests
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/installer/util/copy_tree_work_item.cc ('k') | chrome/installer/util/create_dir_work_item.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/installer/util/create_dir_work_item.h
diff --git a/chrome/installer/util/create_dir_work_item.h b/chrome/installer/util/create_dir_work_item.h
index d0718d19c7681ba371407ad6bbfee416c27a3d04..217196d1e1e063c9f77892dd898eb34fb49b0829 100644
--- a/chrome/installer/util/create_dir_work_item.h
+++ b/chrome/installer/util/create_dir_work_item.h
@@ -16,19 +16,18 @@
public:
~CreateDirWorkItem() override;
- private:
- friend class WorkItem;
-
- explicit CreateDirWorkItem(const base::FilePath& path);
-
- // WorkItem:
- bool DoImpl() override;
+ bool Do() override;
// Rollback tries to remove all directories created along the path.
// If the leaf directory or one of the intermediate directories are not
// empty, the non-empty directory and its parent directories will not be
// removed.
- void RollbackImpl() override;
+ void Rollback() override;
+
+ private:
+ friend class WorkItem;
+
+ explicit CreateDirWorkItem(const base::FilePath& path);
// Get the top most directory that needs to be created in order to create
// "path_", and set "top_path_" accordingly. if "path_" already exists,
« no previous file with comments | « chrome/installer/util/copy_tree_work_item.cc ('k') | chrome/installer/util/create_dir_work_item.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698