Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3670)

Unified Diff: chrome/installer/util/callback_work_item.h

Issue 1976443005: Revert of Add best-effort/allow rollback flags on WorkItem. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@simple_list_tests
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/installer/util/BUILD.gn ('k') | chrome/installer/util/callback_work_item.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/installer/util/callback_work_item.h
diff --git a/chrome/installer/util/callback_work_item.h b/chrome/installer/util/callback_work_item.h
index bcfd56c8833caefa4bcc3cde1723693544c19129..3cc22f656ed415a4c1453444d0bffe700ba76b8c 100644
--- a/chrome/installer/util/callback_work_item.h
+++ b/chrome/installer/util/callback_work_item.h
@@ -35,6 +35,9 @@
public:
~CallbackWorkItem() override;
+ bool Do() override;
+ void Rollback() override;
+
bool IsRollback() const;
private:
@@ -46,12 +49,7 @@
RS_BACKWARD,
};
- explicit CallbackWorkItem(
- base::Callback<bool(const CallbackWorkItem&)> callback);
-
- // WorkItem:
- bool DoImpl() override;
- void RollbackImpl() override;
+ CallbackWorkItem(base::Callback<bool(const CallbackWorkItem&)> callback);
base::Callback<bool(const CallbackWorkItem&)> callback_;
RollState roll_state_;
« no previous file with comments | « chrome/installer/util/BUILD.gn ('k') | chrome/installer/util/callback_work_item.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698