Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(347)

Issue 1924703002: Rename gfx::Display/Screen to display::Display/Screen in ash (Closed)

Created:
4 years, 7 months ago by oshima
Modified:
4 years, 7 months ago
Reviewers:
stevenjb
CC:
chromium-reviews, sadrul, mlamouri+watch-screen-orientation_chromium.org, jam, dcheng, darin-cc_chromium.org, oshima+watch_chromium.org, kalyank
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename gfx::Display/Screen to display::Display/Screen in ash plus cleanups BUG=597761 TBR=stevenjb@chromium.org Committed: https://crrev.com/f84b0da72c726106655120b00323065af4dcc2ac Cr-Commit-Position: refs/heads/master@{#390152}

Patch Set 1 : #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1545 lines, -1419 lines) Patch
M ash/BUILD.gn View 2 chunks +1 line, -1 line 0 comments Download
M ash/accelerators/accelerator_controller.cc View 4 chunks +16 lines, -16 lines 0 comments Download
M ash/accelerators/accelerator_controller_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/content/display/screen_orientation_controller_chromeos_unittest.cc View 26 chunks +70 lines, -70 lines 0 comments Download
M ash/content/keyboard_overlay/keyboard_overlay_delegate.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M ash/content/keyboard_overlay/keyboard_overlay_delegate_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M ash/content/keyboard_overlay/keyboard_overlay_view.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/desktop_background/desktop_background_controller.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M ash/desktop_background/desktop_background_view.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M ash/dip_unittest.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M ash/display/cursor_window_controller.h View 3 chunks +3 lines, -3 lines 0 comments Download
M ash/display/cursor_window_controller.cc View 4 chunks +11 lines, -11 lines 0 comments Download
M ash/display/cursor_window_controller_unittest.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M ash/display/display_change_observer_chromeos.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M ash/display/display_color_manager_chromeos.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/display/display_configuration_controller.h View 2 chunks +3 lines, -3 lines 0 comments Download
M ash/display/display_configuration_controller.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/display/display_info.h View 5 chunks +16 lines, -12 lines 0 comments Download
M ash/display/display_info.cc View 12 chunks +28 lines, -27 lines 0 comments Download
M ash/display/display_info_unittest.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M ash/display/display_layout_store.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M ash/display/display_manager.h View 12 chunks +16 lines, -18 lines 0 comments Download
M ash/display/display_manager.cc View 42 chunks +103 lines, -98 lines 0 comments Download
M ash/display/display_manager_unittest.cc View 45 chunks +139 lines, -119 lines 0 comments Download
M ash/display/display_util.h View 3 chunks +3 lines, -4 lines 0 comments Download
M ash/display/display_util.cc View 9 chunks +14 lines, -13 lines 0 comments Download
M ash/display/event_transformation_handler.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M ash/display/extended_mouse_warp_controller.h View 2 chunks +6 lines, -2 lines 0 comments Download
M ash/display/extended_mouse_warp_controller.cc View 6 chunks +10 lines, -10 lines 0 comments Download
M ash/display/extended_mouse_warp_controller_unittest.cc View 7 chunks +23 lines, -17 lines 0 comments Download
M ash/display/mirror_window_controller.h View 2 chunks +6 lines, -2 lines 0 comments Download
M ash/display/mirror_window_controller.cc View 10 chunks +14 lines, -11 lines 0 comments Download
M ash/display/mirror_window_controller_unittest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M ash/display/resolution_notification_controller.h View 3 chunks +6 lines, -6 lines 0 comments Download
M ash/display/resolution_notification_controller.cc View 5 chunks +10 lines, -11 lines 0 comments Download
M ash/display/resolution_notification_controller_unittest.cc View 4 chunks +6 lines, -4 lines 0 comments Download
M ash/display/root_window_transformers.h View 2 chunks +6 lines, -2 lines 0 comments Download
M ash/display/root_window_transformers.cc View 8 chunks +18 lines, -18 lines 0 comments Download
M ash/display/root_window_transformers_unittest.cc View 14 chunks +33 lines, -25 lines 0 comments Download
M ash/display/screen_ash.h View 2 chunks +19 lines, -17 lines 0 comments Download
M ash/display/screen_ash.cc View 7 chunks +45 lines, -36 lines 0 comments Download
M ash/display/screen_ash_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/display/screen_orientation_controller_chromeos.h View 5 chunks +8 lines, -8 lines 0 comments Download
M ash/display/screen_orientation_controller_chromeos.cc View 15 chunks +55 lines, -55 lines 0 comments Download
M ash/display/screen_position_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/display/screen_position_controller.cc View 6 chunks +7 lines, -7 lines 0 comments Download
M ash/display/screen_position_controller_unittest.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M ash/display/shared_display_edge_indicator.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M ash/display/shared_display_edge_indicator.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M ash/display/unified_mouse_warp_controller.cc View 5 chunks +7 lines, -7 lines 0 comments Download
M ash/display/unified_mouse_warp_controller_unittest.cc View 5 chunks +6 lines, -6 lines 0 comments Download
M ash/display/window_tree_host_manager.h View 5 chunks +8 lines, -10 lines 0 comments Download
M ash/display/window_tree_host_manager.cc View 24 chunks +46 lines, -41 lines 0 comments Download
M ash/display/window_tree_host_manager_unittest.cc View 1 40 chunks +110 lines, -95 lines 0 comments Download
M ash/drag_drop/drag_drop_tracker.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M ash/extended_desktop_unittest.cc View 6 chunks +14 lines, -14 lines 0 comments Download
M ash/first_run/first_run_helper_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/frame/caption_buttons/frame_size_button_unittest.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M ash/host/ash_window_tree_host_x11.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M ash/magnifier/magnification_controller.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M ash/magnifier/magnification_controller_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/magnifier/partial_magnification_controller.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M ash/mus/sysui_application.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/root_window_controller.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M ash/root_window_controller_unittest.cc View 1 chunk +6 lines, -3 lines 0 comments Download
M ash/root_window_settings.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M ash/rotator/screen_rotation_animator.h View 2 chunks +6 lines, -5 lines 0 comments Download
M ash/rotator/screen_rotation_animator.cc View 5 chunks +10 lines, -10 lines 0 comments Download
M ash/screen_util.h View 3 chunks +7 lines, -3 lines 0 comments Download
M ash/screen_util.cc View 5 chunks +14 lines, -12 lines 0 comments Download
M ash/shelf/overflow_bubble.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M ash/shelf/overflow_bubble_view.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M ash/shelf/shelf_bezel_event_filter.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/shelf/shelf_layout_manager.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M ash/shelf/shelf_layout_manager_unittest.cc View 14 chunks +26 lines, -23 lines 0 comments Download
M ash/shelf/shelf_unittest.cc View 1 1 chunk +0 lines, -2 lines 0 comments Download
M ash/shelf/shelf_widget_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M ash/shelf/shelf_window_watcher.h View 3 chunks +6 lines, -6 lines 0 comments Download
M ash/shelf/shelf_window_watcher.cc View 4 chunks +7 lines, -8 lines 0 comments Download
M ash/shell.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/shell.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M ash/shell/content/client/shell_browser_main_parts.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M ash/shell/window_watcher.h View 3 chunks +6 lines, -6 lines 0 comments Download
M ash/shell/window_watcher.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M ash/system/audio/tray_audio.h View 3 chunks +6 lines, -6 lines 0 comments Download
M ash/system/audio/tray_audio.cc View 3 chunks +10 lines, -10 lines 0 comments Download
M ash/system/chromeos/audio/tray_audio_chromeos.h View 1 chunk +4 lines, -4 lines 0 comments Download
M ash/system/chromeos/audio/tray_audio_chromeos.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M ash/system/chromeos/brightness/tray_brightness.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/system/chromeos/rotation/tray_rotation_lock.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M ash/system/chromeos/rotation/tray_rotation_lock_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M ash/system/chromeos/tray_display.cc View 10 chunks +22 lines, -20 lines 0 comments Download
M ash/system/chromeos/tray_display_unittest.cc View 10 chunks +18 lines, -16 lines 0 comments Download
M ash/system/overview/overview_button_tray_unittest.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M ash/system/status_area_widget.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M ash/system/tray/system_tray.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M ash/system/tray/tray_background_view.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M ash/system/web_notification/ash_popup_alignment_delegate.h View 6 chunks +14 lines, -10 lines 0 comments Download
M ash/system/web_notification/ash_popup_alignment_delegate.cc View 5 chunks +11 lines, -12 lines 0 comments Download
M ash/system/web_notification/ash_popup_alignment_delegate_unittest.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M ash/system/web_notification/web_notification_tray.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M ash/system/web_notification/web_notification_tray_unittest.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M ash/test/ash_test_base.h View 2 chunks +3 lines, -3 lines 0 comments Download
M ash/test/ash_test_base.cc View 5 chunks +10 lines, -9 lines 0 comments Download
M ash/test/cursor_manager_test_api.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/test/cursor_manager_test_api.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M ash/test/display_manager_test_api.cc View 7 chunks +10 lines, -10 lines 0 comments Download
M ash/test/ui_controls_factory_ash.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M ash/touch/touch_hud_debug.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/touch/touch_hud_debug.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M ash/touch/touch_observer_hud.h View 3 chunks +6 lines, -6 lines 0 comments Download
M ash/touch/touch_observer_hud.cc View 5 chunks +8 lines, -8 lines 0 comments Download
M ash/touch/touch_observer_hud_unittest.cc View 3 chunks +7 lines, -7 lines 0 comments Download
M ash/touch/touch_transformer_controller.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M ash/touch/touch_transformer_controller_unittest.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M ash/touch/touchscreen_util.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/utility/partial_screenshot_controller.h View 3 chunks +6 lines, -6 lines 0 comments Download
M ash/utility/partial_screenshot_controller.cc View 4 chunks +7 lines, -8 lines 0 comments Download
M ash/wm/ash_native_cursor_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/ash_native_cursor_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/ash_native_cursor_manager_unittest.cc View 7 chunks +10 lines, -10 lines 0 comments Download
M ash/wm/aura/wm_window_aura.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/wm/aura/wm_window_aura.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M ash/wm/common/default_state.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/wm/common/default_state.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M ash/wm/common/dock/docked_window_layout_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/common/root_window_finder.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M ash/wm/common/window_resizer.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M ash/wm/common/window_state.cc View 1 1 chunk +0 lines, -2 lines 0 comments Download
M ash/wm/common/wm_screen_util.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M ash/wm/common/wm_window.h View 3 chunks +6 lines, -2 lines 0 comments Download
M ash/wm/dock/docked_window_layout_manager_unittest.cc View 10 chunks +24 lines, -17 lines 0 comments Download
M ash/wm/dock/docked_window_resizer.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M ash/wm/dock/docked_window_resizer_unittest.cc View 4 chunks +11 lines, -8 lines 0 comments Download
M ash/wm/drag_window_controller.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M ash/wm/drag_window_controller.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M ash/wm/drag_window_resizer.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M ash/wm/drag_window_resizer_unittest.cc View 18 chunks +32 lines, -25 lines 0 comments Download
M ash/wm/immersive_fullscreen_controller.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M ash/wm/lock_layout_manager_unittest.cc View 7 chunks +12 lines, -11 lines 0 comments Download
M ash/wm/lock_window_state.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/maximize_mode/maximize_mode_controller.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M ash/wm/maximize_mode/maximize_mode_controller.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M ash/wm/maximize_mode/maximize_mode_window_manager.h View 3 chunks +6 lines, -6 lines 0 comments Download
M ash/wm/maximize_mode/maximize_mode_window_manager.cc View 4 chunks +8 lines, -6 lines 0 comments Download
M ash/wm/maximize_mode/maximize_mode_window_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/maximize_mode/maximize_mode_window_state.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M ash/wm/maximize_mode/scoped_disable_internal_mouse_and_keyboard_x11.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M ash/wm/overview/window_grid.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/wm/overview/window_selector.h View 3 chunks +9 lines, -10 lines 0 comments Download
M ash/wm/overview/window_selector.cc View 4 chunks +6 lines, -7 lines 0 comments Download
M ash/wm/panels/panel_layout_manager_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M ash/wm/panels/panel_window_resizer.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M ash/wm/system_gesture_event_filter_unittest.cc View 4 chunks +3 lines, -3 lines 0 comments Download
M ash/wm/system_modal_container_layout_manager_unittest.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M ash/wm/toplevel_window_event_handler.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M ash/wm/toplevel_window_event_handler_unittest.cc View 5 chunks +7 lines, -6 lines 0 comments Download
M ash/wm/window_animations.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/wm/window_cycle_controller_unittest.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M ash/wm/window_manager_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/wm/window_positioner.h View 2 chunks +5 lines, -1 line 0 comments Download
M ash/wm/window_positioner.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M ash/wm/window_positioner_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/wm/window_state_unittest.cc View 7 chunks +7 lines, -7 lines 0 comments Download
M ash/wm/window_util.cc View 1 1 chunk +0 lines, -2 lines 0 comments Download
M ash/wm/workspace/multi_window_resize_controller.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M ash/wm/workspace/multi_window_resize_controller_unittest.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M ash/wm/workspace/workspace_event_handler_unittest.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M ash/wm/workspace/workspace_layout_manager.cc View 4 chunks +8 lines, -6 lines 0 comments Download
M ash/wm/workspace/workspace_layout_manager_unittest.cc View 13 chunks +14 lines, -14 lines 0 comments Download
M ash/wm/workspace/workspace_window_resizer.cc View 3 chunks +6 lines, -5 lines 0 comments Download
M ash/wm/workspace/workspace_window_resizer_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M ash/wm/workspace_controller_unittest.cc View 3 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 29 (18 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1924703002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1924703002/20001
4 years, 7 months ago (2016-04-27 01:34:11 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-04-27 02:19:20 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1924703002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1924703002/60001
4 years, 7 months ago (2016-04-27 16:42:02 UTC) #7
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/161424)
4 years, 7 months ago (2016-04-27 16:59:11 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1924703002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1924703002/80001
4 years, 7 months ago (2016-04-27 17:24:29 UTC) #11
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1924703002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1924703002/100001
4 years, 7 months ago (2016-04-27 18:10:13 UTC) #16
oshima
4 years, 7 months ago (2016-04-27 18:23:50 UTC) #20
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-04-27 19:15:57 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1924703002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1924703002/100001
4 years, 7 months ago (2016-04-27 19:38:53 UTC) #25
commit-bot: I haz the power
Committed patchset #2 (id:100001)
4 years, 7 months ago (2016-04-27 19:47:31 UTC) #27
commit-bot: I haz the power
4 years, 7 months ago (2016-04-30 17:12:02 UTC) #28
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f84b0da72c726106655120b00323065af4dcc2ac
Cr-Commit-Position: refs/heads/master@{#390152}

Powered by Google App Engine
This is Rietveld 408576698