Convert //components/policy from scoped_ptr to std::unique_ptr

Convert //components/policy from scoped_ptr to std::unique_ptr

BUG=554298
R=tnagel@chromium.org

Committed: https://crrev.com/a3451b74e1aac0c538d7d6824bd714553eb0141e
Cr-Commit-Position: refs/heads/master@{#388603}

[dcheng, 2016-04-20 01:05:26]

This is largely a search and replace. There's probably some IWYU errors (files
that don't include memory when they should and those that do when they
shouldn't), but fixing those is out-of-scope for this conversion work.

[Thiemo Nagel, 2016-04-20 20:34:19]

LGTM % comments (all but 1 are optional)

Many thanks for doing the conversion!

https://codereview.chromium.org/1902633006/diff/1/components/policy/core/comm...
File components/policy/core/common/async_policy_provider_unittest.cc (right):

https://codereview.chromium.org/1902633006/diff/1/components/policy/core/comm...
components/policy/core/common/async_policy_provider_unittest.cc:49: // because
Please fix line wrapping and convert in-comment mentions of scoped_ptr.

https://codereview.chromium.org/1902633006/diff/1/components/policy/core/comm...
File components/policy/core/common/cloud/cloud_policy_client.cc (right):

https://codereview.chromium.org/1902633006/diff/1/components/policy/core/comm...
components/policy/core/common/cloud/cloud_policy_client.cc:278:
std::unique_ptr<DeviceManagementRequestJob> request_job(service_->CreateJob(
Optional nit: I'd maybe wrap that after "request_job(" even at the expense of
requiring an extra line.

https://codereview.chromium.org/1902633006/diff/1/components/policy/core/comm...
components/policy/core/common/cloud/cloud_policy_client.cc:331:
std::unique_ptr<DeviceManagementRequestJob> request_job(service_->CreateJob(
Optional nit: same as above.

https://codereview.chromium.org/1902633006/diff/1/components/policy/core/comm...
components/policy/core/common/cloud/cloud_policy_client.cc:357:
std::unique_ptr<DeviceManagementRequestJob> request_job(service_->CreateJob(
same

https://codereview.chromium.org/1902633006/diff/1/components/policy/core/comm...
components/policy/core/common/cloud/cloud_policy_client.cc:382:
std::unique_ptr<DeviceManagementRequestJob> request_job(service_->CreateJob(
same

https://codereview.chromium.org/1902633006/diff/1/components/policy/core/comm...
File components/policy/core/common/cloud/cloud_policy_validator_unittest.cc
(right):

https://codereview.chromium.org/1902633006/diff/1/components/policy/core/comm...
components/policy/core/common/cloud/cloud_policy_validator_unittest.cc:64:
std::unique_ptr<enterprise_management::PolicyFetchResponse>
Optional nit: We often use

namespace em = enterprise_management;

to avoid such ugly wrappings.

https://codereview.chromium.org/1902633006/diff/1/components/policy/core/comm...
File components/policy/core/common/policy_loader_win.cc (right):

https://codereview.chromium.org/1902633006/diff/1/components/policy/core/comm...
components/policy/core/common/policy_loader_win.cc:409: return
base::WrapUnique(new PolicyLoaderWin(
Optional nit: Preserving existing indentation would seem preferable to me.

https://codereview.chromium.org/1902633006/diff/1/components/policy/core/comm...
File components/policy/core/common/preg_parser_win_unittest.cc (right):

https://codereview.chromium.org/1902633006/diff/1/components/policy/core/comm...
components/policy/core/common/preg_parser_win_unittest.cc:62: name,
base::WrapUnique<base::Value>(new base::FundamentalValue(value)));
Optional nit: Keeping existing indentation would seem preferable to me.

[dcheng, 2016-04-20 20:56:32]

https://codereview.chromium.org/1902633006/diff/1/components/policy/core/comm...
File components/policy/core/common/async_policy_provider_unittest.cc (right):

https://codereview.chromium.org/1902633006/diff/1/components/policy/core/comm...
components/policy/core/common/async_policy_provider_unittest.cc:49: // because
On 2016/04/20 at 20:34:19, Thiemo Nagel wrote:
> Please fix line wrapping and convert in-comment mentions of scoped_ptr.

Done.

https://codereview.chromium.org/1902633006/diff/1/components/policy/core/comm...
File components/policy/core/common/cloud/cloud_policy_client.cc (right):

https://codereview.chromium.org/1902633006/diff/1/components/policy/core/comm...
components/policy/core/common/cloud/cloud_policy_client.cc:278:
std::unique_ptr<DeviceManagementRequestJob> request_job(service_->CreateJob(
On 2016/04/20 at 20:34:19, Thiemo Nagel wrote:
> Optional nit: I'd maybe wrap that after "request_job(" even at the expense of
requiring an extra line.

This and the other changes are due to clang-format. I'd prefer to leave them
as-is, just to avoid fighting the tooling.

https://codereview.chromium.org/1902633006/diff/1/components/policy/core/comm...
File components/policy/core/common/cloud/cloud_policy_validator_unittest.cc
(right):

https://codereview.chromium.org/1902633006/diff/1/components/policy/core/comm...
components/policy/core/common/cloud/cloud_policy_validator_unittest.cc:64:
std::unique_ptr<enterprise_management::PolicyFetchResponse>
On 2016/04/20 at 20:34:19, Thiemo Nagel wrote:
> Optional nit: We often use
> 
> namespace em = enterprise_management;
> 
> to avoid such ugly wrappings.

Done.

https://codereview.chromium.org/1902633006/diff/1/components/policy/core/comm...
File components/policy/core/common/policy_loader_win.cc (right):

https://codereview.chromium.org/1902633006/diff/1/components/policy/core/comm...
components/policy/core/common/policy_loader_win.cc:409: return
base::WrapUnique(new PolicyLoaderWin(
On 2016/04/20 at 20:34:19, Thiemo Nagel wrote:
> Optional nit: Preserving existing indentation would seem preferable to me.

I'd prefer not to fight clang-format here. If we keep trying to fight
clang-format, future clean-up CLs will just have to keep manually reverting an
increasingly large amount of code. It's very likely that these will be rewritten
to base::MakeUnique<T>(...) at some point in the future.

https://codereview.chromium.org/1902633006/diff/1/components/policy/core/comm...
File components/policy/core/common/preg_parser_win_unittest.cc (right):

https://codereview.chromium.org/1902633006/diff/1/components/policy/core/comm...
components/policy/core/common/preg_parser_win_unittest.cc:62: name,
base::WrapUnique<base::Value>(new base::FundamentalValue(value)));
On 2016/04/20 at 20:34:19, Thiemo Nagel wrote:
> Optional nit: Keeping existing indentation would seem preferable to me.

See previous reply.

[dcheng, 2016-04-20 20:56:47]

The CQ bit was checked by dcheng@chromium.org

[dcheng, 2016-04-20 20:56:48]

The patchset sent to the CQ was uploaded after l-g-t-m from tnagel@chromium.org
Link to the patchset: https://codereview.chromium.org/1902633006/#ps20001
(title: "Address comments and use namespace alias")

[commit-bot: I haz the power, 2016-04-20 20:57:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1902633006/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1902633006/20001

[commit-bot: I haz the power, 2016-04-20 21:41:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-20 21:41:36]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[dcheng, 2016-04-20 21:43:21]

The CQ bit was checked by dcheng@chromium.org

[commit-bot: I haz the power, 2016-04-20 21:43:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1902633006/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1902633006/20001

[commit-bot: I haz the power, 2016-04-20 23:57:22]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-04-22 19:27:41]

Description was changed from

==========
Convert //components/policy from scoped_ptr to std::unique_ptr

BUG=554298
R=tnagel@chromium.org
==========

to

==========
Convert //components/policy from scoped_ptr to std::unique_ptr

BUG=554298
R=tnagel@chromium.org

Committed: https://crrev.com/a3451b74e1aac0c538d7d6824bd714553eb0141e
Cr-Commit-Position: refs/heads/master@{#388603}
==========

[commit-bot: I haz the power, 2016-04-22 19:27:43]

Patchset 2 (id:??) landed as
https://crrev.com/a3451b74e1aac0c538d7d6824bd714553eb0141e
Cr-Commit-Position: refs/heads/master@{#388603}