components/policy/core/common/cloud/component_cloud_policy_updater.cc - Issue 1902633006: Convert //components/policy from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/policy/core/common/cloud/component_cloud_policy_updater.cc

Issue 1902633006: Convert //components/policy from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address comments and use namespace alias Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/policy/core/common/cloud/component_cloud_policy_updater.h ('k') | components/policy/core/common/cloud/component_cloud_policy_updater_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/policy/core/common/cloud/component_cloud_policy_updater.cc

diff --git a/components/policy/core/common/cloud/component_cloud_policy_updater.cc b/components/policy/core/common/cloud/component_cloud_policy_updater.cc

index cea825dd35d8ab1acd65173ae3b0f2e97a543721..69a0b57cc504a54839d0d8a1f8e4ebce66ecf51f 100644

--- a/components/policy/core/common/cloud/component_cloud_policy_updater.cc

+++ b/components/policy/core/common/cloud/component_cloud_policy_updater.cc

@@ -37,7 +37,7 @@ const int64_t kMaxParallelPolicyDataFetches = 2;

ComponentCloudPolicyUpdater::ComponentCloudPolicyUpdater(

scoped_refptr<base::SequencedTaskRunner> task_runner,

- scoped_ptr<ExternalPolicyDataFetcher> external_policy_data_fetcher,

+ std::unique_ptr<ExternalPolicyDataFetcher> external_policy_data_fetcher,

ComponentCloudPolicyStore* store)

: store_(store),

external_policy_data_updater_(task_runner,

@@ -48,7 +48,7 @@ ComponentCloudPolicyUpdater::~ComponentCloudPolicyUpdater() {

}

void ComponentCloudPolicyUpdater::UpdateExternalPolicy(

- scoped_ptr<em::PolicyFetchResponse> response) {

+ std::unique_ptr<em::PolicyFetchResponse> response) {

// Keep a serialized copy of |response|, to cache it later.

// The policy is also rejected if it exceeds the maximum size.

std::string serialized_response;