components/policy/core/common/cloud/mock_cloud_external_data_manager.h - Issue 1902633006: Convert //components/policy from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/policy/core/common/cloud/mock_cloud_external_data_manager.h

Issue 1902633006: Convert //components/policy from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address comments and use namespace alias Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/policy/core/common/cloud/external_policy_data_updater_unittest.cc ('k') | components/policy/core/common/cloud/mock_cloud_external_data_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/policy/core/common/cloud/mock_cloud_external_data_manager.h

diff --git a/components/policy/core/common/cloud/mock_cloud_external_data_manager.h b/components/policy/core/common/cloud/mock_cloud_external_data_manager.h

index 434e54bd6f3bc3ce0f31a7235d382a9fd082ef89..0cceb80fb9e12a9c1352ddcff12341d87a56ff88 100644

--- a/components/policy/core/common/cloud/mock_cloud_external_data_manager.h

+++ b/components/policy/core/common/cloud/mock_cloud_external_data_manager.h

@@ -5,11 +5,11 @@

#ifndef COMPONENTS_POLICY_CORE_COMMON_CLOUD_MOCK_CLOUD_EXTERNAL_DATA_MANAGER_H_

#define COMPONENTS_POLICY_CORE_COMMON_CLOUD_MOCK_CLOUD_EXTERNAL_DATA_MANAGER_H_

+#include <memory>

#include <string>

#include "base/macros.h"

#include "base/memory/ref_counted.h"

-#include "base/memory/scoped_ptr.h"

#include "components/policy/core/common/cloud/cloud_external_data_manager.h"

#include "components/policy/core/common/external_data_fetcher.h"

#include "testing/gmock/include/gmock/gmock.h"

@@ -33,7 +33,7 @@ class MockCloudExternalDataManager : public CloudExternalDataManager {

MOCK_METHOD2(Fetch, void(const std::string&,

const ExternalDataFetcher::FetchCallback&));

- scoped_ptr<ExternalDataFetcher> CreateExternalDataFetcher(

+ std::unique_ptr<ExternalDataFetcher> CreateExternalDataFetcher(

const std::string& policy);

private: