components/policy/core/common/external_data_fetcher.h - Issue 1902633006: Convert //components/policy from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/policy/core/common/external_data_fetcher.h

Issue 1902633006: Convert //components/policy from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address comments and use namespace alias Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/policy/core/common/configuration_policy_provider_test.h ('k') | components/policy/core/common/external_data_fetcher.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/policy/core/common/external_data_fetcher.h

diff --git a/components/policy/core/common/external_data_fetcher.h b/components/policy/core/common/external_data_fetcher.h

index 25ea41a263a57815774aa246d5d1092323c1c854..0c014e794bb4efe806883250e5a35944e562d542 100644

--- a/components/policy/core/common/external_data_fetcher.h

+++ b/components/policy/core/common/external_data_fetcher.h

@@ -5,10 +5,10 @@

#ifndef COMPONENTS_POLICY_CORE_COMMON_EXTERNAL_DATA_FETCHER_H_

#define COMPONENTS_POLICY_CORE_COMMON_EXTERNAL_DATA_FETCHER_H_

+#include <memory>

#include <string>

#include "base/callback_forward.h"

-#include "base/memory/scoped_ptr.h"

#include "base/memory/weak_ptr.h"

#include "components/policy/policy_export.h"

@@ -20,7 +20,7 @@ class ExternalDataManager;

// data for a policy.

class POLICY_EXPORT ExternalDataFetcher {

public:

- typedef base::Callback<void(scoped_ptr<std::string>)> FetchCallback;

+ typedef base::Callback<void(std::unique_ptr<std::string>)> FetchCallback;

// This instance's Fetch() method will instruct the |manager| to retrieve the

// external data referenced by the given |policy|.