components/policy/core/common/cloud/external_policy_data_updater.cc - Issue 1902633006: Convert //components/policy from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/policy/core/common/cloud/external_policy_data_updater.cc

Issue 1902633006: Convert //components/policy from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address comments and use namespace alias Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/policy/core/common/cloud/external_policy_data_updater.h ('k') | components/policy/core/common/cloud/external_policy_data_updater_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/policy/core/common/cloud/external_policy_data_updater.cc

diff --git a/components/policy/core/common/cloud/external_policy_data_updater.cc b/components/policy/core/common/cloud/external_policy_data_updater.cc

index f8c5d81c24057703197c7f96ac48dd8d966fd747..eebbd9e1f880fe1bea6e2b7edd1d06576418ab73 100644

--- a/components/policy/core/common/cloud/external_policy_data_updater.cc

+++ b/components/policy/core/common/cloud/external_policy_data_updater.cc

@@ -125,7 +125,7 @@ class ExternalPolicyDataUpdater::FetchJob

void Start();

void OnFetchFinished(ExternalPolicyDataFetcher::Result result,

- scoped_ptr<std::string> data);

+ std::unique_ptr<std::string> data);

private:

void OnFailed(net::BackoffEntry* backoff_entry);

@@ -217,7 +217,7 @@ void ExternalPolicyDataUpdater::FetchJob::Start() {

void ExternalPolicyDataUpdater::FetchJob::OnFetchFinished(

ExternalPolicyDataFetcher::Result result,

- scoped_ptr<std::string> data) {

+ std::unique_ptr<std::string> data) {

// The fetch job in the |external_policy_data_fetcher_| is finished.

fetch_job_ = NULL;

@@ -293,7 +293,7 @@ void ExternalPolicyDataUpdater::FetchJob::Reschedule() {

ExternalPolicyDataUpdater::ExternalPolicyDataUpdater(

scoped_refptr<base::SequencedTaskRunner> task_runner,

- scoped_ptr<ExternalPolicyDataFetcher> external_policy_data_fetcher,

+ std::unique_ptr<ExternalPolicyDataFetcher> external_policy_data_fetcher,

size_t max_parallel_fetches)

: task_runner_(task_runner),

external_policy_data_fetcher_(external_policy_data_fetcher.release()),