components/policy/core/common/remote_commands/remote_commands_queue.cc - Issue 1902633006: Convert //components/policy from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/policy/core/common/remote_commands/remote_commands_queue.cc

Issue 1902633006: Convert //components/policy from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address comments and use namespace alias Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/policy/core/common/remote_commands/remote_commands_queue.h ('k') | components/policy/core/common/remote_commands/remote_commands_queue_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/policy/core/common/remote_commands/remote_commands_queue.cc

diff --git a/components/policy/core/common/remote_commands/remote_commands_queue.cc b/components/policy/core/common/remote_commands/remote_commands_queue.cc

index e3b28477de93268281539fc46f556cc322bd8dc0..210217268eb7886eaa9a90784c08a8096a313b9d 100644

--- a/components/policy/core/common/remote_commands/remote_commands_queue.cc

+++ b/components/policy/core/common/remote_commands/remote_commands_queue.cc

@@ -35,7 +35,7 @@ void RemoteCommandsQueue::RemoveObserver(Observer* observer) {

observer_list_.RemoveObserver(observer);

}

-void RemoteCommandsQueue::AddJob(scoped_ptr<RemoteCommandJob> job) {

+void RemoteCommandsQueue::AddJob(std::unique_ptr<RemoteCommandJob> job) {

incoming_commands_.push(linked_ptr<RemoteCommandJob>(job.release()));

if (!running_command_)

@@ -43,7 +43,7 @@ void RemoteCommandsQueue::AddJob(scoped_ptr<RemoteCommandJob> job) {

}

void RemoteCommandsQueue::SetClockForTesting(

- scoped_ptr<base::TickClock> clock) {

+ std::unique_ptr<base::TickClock> clock) {

clock_ = std::move(clock);

}