components/policy/core/common/remote_commands/remote_commands_factory.h - Issue 1902633006: Convert //components/policy from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/policy/core/common/remote_commands/remote_commands_factory.h

Issue 1902633006: Convert //components/policy from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address comments and use namespace alias Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/policy/core/common/remote_commands/remote_command_job.cc ('k') | components/policy/core/common/remote_commands/remote_commands_queue.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/policy/core/common/remote_commands/remote_commands_factory.h

diff --git a/components/policy/core/common/remote_commands/remote_commands_factory.h b/components/policy/core/common/remote_commands/remote_commands_factory.h

index 41a0d7b72bd3e89b62b8a2d2b5b3b516add12321..1ef1f5404895c8583345ca0d431cf6eaadf61200 100644

--- a/components/policy/core/common/remote_commands/remote_commands_factory.h

+++ b/components/policy/core/common/remote_commands/remote_commands_factory.h

@@ -5,8 +5,9 @@

#ifndef COMPONENTS_POLICY_CORE_COMMON_REMOTE_COMMANDS_REMOTE_COMMANDS_FACTORY_H_

#define COMPONENTS_POLICY_CORE_COMMON_REMOTE_COMMANDS_REMOTE_COMMANDS_FACTORY_H_

+#include <memory>

#include "base/macros.h"

-#include "base/memory/scoped_ptr.h"

#include "components/policy/policy_export.h"

#include "policy/proto/device_management_backend.pb.h"

@@ -19,7 +20,7 @@ class POLICY_EXPORT RemoteCommandsFactory {

public:

virtual ~RemoteCommandsFactory();

- virtual scoped_ptr<RemoteCommandJob> BuildJobForType(

+ virtual std::unique_ptr<RemoteCommandJob> BuildJobForType(

enterprise_management::RemoteCommand_Type type) = 0;

private: