components/policy/core/common/cloud/user_info_fetcher.cc - Issue 1902633006: Convert //components/policy from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/policy/core/common/cloud/user_info_fetcher.cc

Issue 1902633006: Convert //components/policy from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address comments and use namespace alias Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/policy/core/common/cloud/user_info_fetcher.h ('k') | components/policy/core/common/cloud/user_info_fetcher_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/policy/core/common/cloud/user_info_fetcher.cc

diff --git a/components/policy/core/common/cloud/user_info_fetcher.cc b/components/policy/core/common/cloud/user_info_fetcher.cc

index 0212bb99de0ada6b1ebabafd96c43e3d7ab2d22b..bf5c78cc03402ab74656ad032c519a15a5ef2372 100644

--- a/components/policy/core/common/cloud/user_info_fetcher.cc

+++ b/components/policy/core/common/cloud/user_info_fetcher.cc

@@ -78,7 +78,8 @@ void UserInfoFetcher::OnURLFetchComplete(const net::URLFetcher* source) {

std::string unparsed_data;

source->GetResponseAsString(&unparsed_data);

DVLOG(1) << "Received UserInfo response: " << unparsed_data;

- scoped_ptr<base::Value> parsed_value = base::JSONReader::Read(unparsed_data);

+ std::unique_ptr<base::Value> parsed_value =

+ base::JSONReader::Read(unparsed_data);

base::DictionaryValue* dict;

if (parsed_value.get() && parsed_value->GetAsDictionary(&dict)) {

delegate_->OnGetUserInfoSuccess(dict);