components/policy/core/common/remote_commands/remote_command_job.cc - Issue 1902633006: Convert //components/policy from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/policy/core/common/remote_commands/remote_command_job.cc

Issue 1902633006: Convert //components/policy from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address comments and use namespace alias Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/policy/core/common/remote_commands/remote_command_job.h ('k') | components/policy/core/common/remote_commands/remote_commands_factory.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/policy/core/common/remote_commands/remote_command_job.cc

diff --git a/components/policy/core/common/remote_commands/remote_command_job.cc b/components/policy/core/common/remote_commands/remote_command_job.cc

index 64f897f13a8cf62536b4ff4b9d70f8e4522d567d..fb7caacebea062d8e59863335e5520c9626f61e5 100644

--- a/components/policy/core/common/remote_commands/remote_command_job.cc

+++ b/components/policy/core/common/remote_commands/remote_command_job.cc

@@ -115,7 +115,7 @@ bool RemoteCommandJob::IsExecutionFinished() const {

return status_ == SUCCEEDED || status_ == FAILED || status_ == TERMINATED;

}

-scoped_ptr<std::string> RemoteCommandJob::GetResultPayload() const {

+std::unique_ptr<std::string> RemoteCommandJob::GetResultPayload() const {

DCHECK(thread_checker_.CalledOnValidThread());

DCHECK(status_ == SUCCEEDED || status_ == FAILED);

@@ -142,7 +142,7 @@ void RemoteCommandJob::TerminateImpl() {

void RemoteCommandJob::OnCommandExecutionFinishedWithResult(

bool succeeded,

- scoped_ptr<RemoteCommandJob::ResultPayload> result_payload) {

+ std::unique_ptr<RemoteCommandJob::ResultPayload> result_payload) {

DCHECK(thread_checker_.CalledOnValidThread());

DCHECK_EQ(RUNNING, status_);

status_ = succeeded ? SUCCEEDED : FAILED;