components/policy/core/common/remote_commands/testing_remote_commands_server.cc - Issue 1902633006: Convert //components/policy from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/policy/core/common/remote_commands/testing_remote_commands_server.cc

Issue 1902633006: Convert //components/policy from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address comments and use namespace alias Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/policy/core/common/remote_commands/testing_remote_commands_server.h ('k') | components/policy/core/common/schema.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/policy/core/common/remote_commands/testing_remote_commands_server.cc

diff --git a/components/policy/core/common/remote_commands/testing_remote_commands_server.cc b/components/policy/core/common/remote_commands/testing_remote_commands_server.cc

index 53db3e2c3d1f18c2e992d4e2cb9866bfcd28acf1..3f9a65b4e3260c1f646f194d05c77787e8bf476f 100644

--- a/components/policy/core/common/remote_commands/testing_remote_commands_server.cc

+++ b/components/policy/core/common/remote_commands/testing_remote_commands_server.cc

@@ -76,7 +76,7 @@ void TestingRemoteCommandsServer::IssueCommand(

TestingRemoteCommandsServer::RemoteCommands

TestingRemoteCommandsServer::FetchCommands(

- scoped_ptr<RemoteCommandJob::UniqueIDType> last_command_id,

+ std::unique_ptr<RemoteCommandJob::UniqueIDType> last_command_id,

const RemoteCommandResults& previous_job_results) {

base::AutoLock auto_lock(lock_);

@@ -135,7 +135,8 @@ TestingRemoteCommandsServer::FetchCommands(

return fetched_commands;

}

-void TestingRemoteCommandsServer::SetClock(scoped_ptr<base::TickClock> clock) {

+void TestingRemoteCommandsServer::SetClock(

+ std::unique_ptr<base::TickClock> clock) {

DCHECK(thread_checker_.CalledOnValidThread());

clock_ = std::move(clock);

}