components/policy/core/common/cloud/cloud_policy_core_unittest.cc - Issue 1902633006: Convert //components/policy from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/policy/core/common/cloud/cloud_policy_core_unittest.cc

Issue 1902633006: Convert //components/policy from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address comments and use namespace alias Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/policy/core/common/cloud/cloud_policy_core.cc ('k') | components/policy/core/common/cloud/cloud_policy_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/policy/core/common/cloud/cloud_policy_core_unittest.cc

diff --git a/components/policy/core/common/cloud/cloud_policy_core_unittest.cc b/components/policy/core/common/cloud/cloud_policy_core_unittest.cc

index b6fdea566d39cb0783a60882283bb6a45096886e..015ce3cb78416ab60d46374e8beeba3318dcfb84 100644

--- a/components/policy/core/common/cloud/cloud_policy_core_unittest.cc

+++ b/components/policy/core/common/cloud/cloud_policy_core_unittest.cc

@@ -82,7 +82,8 @@ TEST_F(CloudPolicyCoreTest, ConnectAndDisconnect) {

EXPECT_FALSE(core_.refresh_scheduler());

// Connect() brings up client and service.

- core_.Connect(scoped_ptr<CloudPolicyClient>(new MockCloudPolicyClient()));

+ core_.Connect(

+ std::unique_ptr<CloudPolicyClient>(new MockCloudPolicyClient()));

EXPECT_TRUE(core_.client());

EXPECT_TRUE(core_.service());

EXPECT_FALSE(core_.refresh_scheduler());

@@ -112,7 +113,8 @@ TEST_F(CloudPolicyCoreTest, ConnectAndDisconnect) {

TEST_F(CloudPolicyCoreTest, RefreshScheduler) {

EXPECT_FALSE(core_.refresh_scheduler());

- core_.Connect(scoped_ptr<CloudPolicyClient>(new MockCloudPolicyClient()));

+ core_.Connect(

+ std::unique_ptr<CloudPolicyClient>(new MockCloudPolicyClient()));

core_.StartRefreshScheduler();

ASSERT_TRUE(core_.refresh_scheduler());